-
Notifications
You must be signed in to change notification settings - Fork 93
feat: Push notifications permissions - UI #19792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexjba
wants to merge
1
commit into
master
Choose a base branch
from
feat/push-notifications-UI
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (52)
|
607cbb2 to
36e11d6
Compare
6595a6f to
36e11d6
Compare
caybro
reviewed
Jan 28, 2026
Member
caybro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just got some questions, mainly regarding the onboarding and privacy mode
36e11d6 to
b7a5126
Compare
caybro
reviewed
Feb 1, 2026
Adding the possibility for the user to interact with the OS push notification permissions. 1. Adding a `EnablePushNotificationsPopup` component. This component will be shown at start-up. The user can use it to request push notifications permissions or to navigate to OS settings if the permissions cannot be enabled from within the app 2. Hook the push notifications permissions to NotificationsView. The `Enable push notifications` toggle will also ask for push notifications permissions if possible. Otherwise it will show an additional section guiding the user to enable push notifications from OS settings.
b7a5126 to
65a4f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closes #19686
Implements status-im/MobileUI#2
Adding the possibility for the user to interact with the OS push notification permissions.
EnablePushNotificationsPopupcomponent. This component will be shown at start-up. The user can use it to request push notifications permissions or to navigate to OS settings if the permissions cannot be enabled from within the appEnable push notificationstoggle will also ask for push notifications permissions if possible. Otherwise it will show an additional section guiding the user to enable push notifications from OS settings.Affected areas
Notifications settings
Log in
App settings
Push notifications
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Screen_Recording_20260126_133206_Settings.mp4
Screen_Recording_20260126_132824_Status.mp4
Impact on end user
The user can manage OS permissions for push notifications
How to test
Login -> The push notifications popup should appear -> Allow/don't allow
Risk
Low