Skip to content

Conversation

@alexjba
Copy link
Contributor

@alexjba alexjba commented Jan 26, 2026

What does the PR do

Closes #19686

Implements status-im/MobileUI#2

Adding the possibility for the user to interact with the OS push notification permissions.

  1. Adding a EnablePushNotificationsPopup component. This component will be shown at start-up. The user can use it to request push notifications permissions or to navigate to OS settings if the permissions cannot be enabled from within the app
  2. Hook the push notifications permissions to NotificationsView. The Enable push notifications toggle will also ask for push notifications permissions if possible. Otherwise it will show an additional section guiding the user to enable push notifications from OS settings.

Affected areas

Notifications settings
Log in
App settings
Push notifications

Architecture compliance

Screencapture of the functionality

Screen_Recording_20260126_133206_Settings.mp4
Screen_Recording_20260126_132824_Status.mp4

Impact on end user

The user can manage OS permissions for push notifications

How to test

Login -> The push notifications popup should appear -> Allow/don't allow

Risk

Low

@status-im-auto
Copy link
Member

status-im-auto commented Jan 26, 2026

Jenkins Builds

Click to see older builds (52)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 607cbb2 1 2026-01-26 10:51:20 ~9 min android/arm64 🤖apk 📲
✔️ 607cbb2 1 2026-01-26 10:52:33 ~10 min tests/nim 📄log
✔️ 607cbb2 1 2026-01-26 10:54:34 ~12 min ios/aarch64 📱ipa 📲
✖️ 607cbb2 PR19792 2026-01-26 10:56:07 ~4 min tests/e2e-android 📦pkg
✔️ 607cbb2 1 2026-01-26 10:57:00 ~14 min tests/ui 📄log
607cbb2 1 2026-01-26 10:58:59 ~16 min macos/aarch64-nwaku 📄log
✔️ 607cbb2 1 2026-01-26 10:59:39 ~17 min macos/aarch64 🍎dmg
✔️ 36e11d6 2 2026-01-26 11:10:47 ~9 min android/arm64 🤖apk 📲
✔️ 36e11d6 2 2026-01-26 11:11:37 ~10 min tests/nim 📄log
✔️ 36e11d6 2 2026-01-26 11:15:13 ~13 min tests/ui 📄log
✔️ 36e11d6 2 2026-01-26 11:16:21 ~14 min macos/aarch64 🍎dmg
✖️ 36e11d6 PR19792 2026-01-26 11:16:21 ~5 min tests/e2e-android 📦pkg
✔️ 36e11d6 2 2026-01-26 11:16:40 ~15 min ios/aarch64 📱ipa 📲
✔️ 36e11d6 2 2026-01-26 11:21:49 ~20 min linux/x86_64 📦tgz
✔️ 36e11d6 2 2026-01-26 11:21:50 ~20 min linux/x86_64-nwaku 📦tgz
✔️ 36e11d6 2 2026-01-26 11:23:22 ~21 min macos/aarch64-nwaku 🍎dmg
✖️ 36e11d6 9382 2026-01-26 11:24:14 ~2 min tests/e2e 📊rpt
✔️ 36e11d6 2 2026-01-26 11:34:38 ~32 min windows/x86_64 💿exe
✖️ 36e11d6 1555 2026-01-26 12:06:20 ~31 min tests/e2e-windows 📊rpt
✖️ 36e11d6 PR19792 2026-01-27 05:50:03 ~18 min tests/e2e-android 📦pkg
✔️ 36e11d6 4 2026-01-27 09:47:21 ~9 min tests/nim 📄log
✔️ 36e11d6 4 2026-01-27 09:49:51 ~12 min ios/aarch64 📱ipa 📲
✔️ 36e11d6 4 2026-01-27 09:51:04 ~13 min tests/ui 📄log
✖️ 36e11d6 PR19792 2026-01-27 09:52:37 ~5 min tests/e2e-android 📦pkg
✔️ 36e11d6 4 2026-01-27 09:55:57 ~18 min macos/aarch64 🍎dmg
✔️ 36e11d6 4 2026-01-27 09:56:12 ~18 min macos/aarch64-nwaku 🍎dmg
✔️ 36e11d6 4 2026-01-27 09:58:36 ~21 min linux/x86_64 📦tgz
✔️ 36e11d6 4 2026-01-27 09:58:45 ~21 min linux/x86_64-nwaku 📦tgz
✔️ 36e11d6 4 2026-01-27 10:13:07 ~35 min windows/x86_64 💿exe
✔️ 36e11d6 9390 2026-01-27 10:18:33 ~19 min tests/e2e 📊rpt
✖️ 36e11d6 1561 2026-01-27 10:39:52 ~26 min tests/e2e-windows 📊rpt
✖️ 36e11d6 PR19792 2026-01-28 05:53:30 ~22 min tests/e2e-android 📦pkg
✖️ 36e11d6 PR19792 2026-01-30 05:56:53 ~25 min tests/e2e-android 📦pkg
✔️ bd480c4f 3 2026-01-27 05:31:22 ~13 min android/arm64 🤖apk 📲
✔️ fbdd2ef7 5 2026-01-27 09:47:13 ~9 min android/arm64 🤖apk 📲
✔️ af0f852e 6 2026-01-28 05:30:39 ~12 min android/arm64 🤖apk 📲
a54bbe1a 7 2026-01-29 05:28:32 ~9 min android/arm64 📄log
✔️ 38980a3f 8 2026-01-30 05:31:02 ~12 min android/arm64 🤖apk 📲
✔️ 1e28f620 9 2026-01-30 13:58:32 ~9 min android/arm64 🤖apk 📲
✔️ b7a5126 5 2026-01-30 14:01:01 ~11 min tests/nim 📄log
✖️ b7a5126 PR19792 2026-01-30 14:04:11 ~5 min tests/e2e-android 📦pkg
✔️ b7a5126 5 2026-01-30 14:06:47 ~17 min tests/ui 📄log
✔️ b7a5126 5 2026-01-30 14:10:08 ~20 min linux/x86_64-nwaku 📦tgz
✔️ b7a5126 5 2026-01-30 14:11:47 ~22 min linux/x86_64 📦tgz
✔️ b7a5126 5 2026-01-30 14:11:51 ~22 min ios/aarch64 📱ipa 📲
✔️ b7a5126 5 2026-01-30 14:13:14 ~23 min macos/aarch64 🍎dmg
✔️ b7a5126 5 2026-01-30 14:16:40 ~27 min macos/aarch64-nwaku 🍎dmg
✔️ b7a5126 9482 2026-01-30 14:29:21 ~17 min tests/e2e 📊rpt
✖️ b7a5126 PR19792 2026-01-31 06:11:18 ~31 min tests/e2e-android 📦pkg
✖️ b7a5126 PR19792 2026-02-02 06:22:59 ~42 min tests/e2e-android 📦pkg
✔️ f8b9b730 10 2026-01-31 05:39:53 ~21 min android/arm64 🤖apk 📲
✔️ 48be7d22 11 2026-02-02 05:40:44 ~22 min android/arm64 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 65a4f9c 12 2026-02-02 09:34:17 ~9 min android/arm64 🤖apk 📲
✔️ 65a4f9c 6 2026-02-02 09:36:07 ~11 min tests/nim 📄log
✖️ 65a4f9c PR19792 2026-02-02 09:39:44 ~5 min tests/e2e-android 📦pkg
✔️ 65a4f9c 6 2026-02-02 09:39:59 ~15 min ios/aarch64 📱ipa 📲
✔️ 65a4f9c 6 2026-02-02 09:40:33 ~16 min tests/ui 📄log
✔️ 65a4f9c 6 2026-02-02 09:44:05 ~19 min macos/aarch64 🍎dmg
✔️ 65a4f9c 6 2026-02-02 09:44:15 ~19 min macos/aarch64-nwaku 🍎dmg
✔️ 65a4f9c 6 2026-02-02 09:45:47 ~21 min linux/x86_64 📦tgz
✔️ 65a4f9c 6 2026-02-02 09:46:16 ~21 min linux/x86_64-nwaku 📦tgz
✔️ 65a4f9c 9518 2026-02-02 10:07:16 ~21 min tests/e2e 📊rpt
✖️ 65a4f9c PR19792 2026-02-03 06:08:14 ~34 min tests/e2e-android 📦pkg
✔️ 75ecc8ca 13 2026-02-03 05:33:39 ~15 min android/arm64 🤖apk 📲

@alexjba alexjba force-pushed the feat/push-notifications-UI branch from 607cbb2 to 36e11d6 Compare January 26, 2026 11:01
@alexjba alexjba marked this pull request as ready for review January 26, 2026 11:35
@alexjba alexjba requested review from a team, caybro, micieslak and noeliaSD as code owners January 26, 2026 11:35
@alexjba alexjba requested a review from a team as a code owner January 27, 2026 09:34
@alexjba alexjba force-pushed the feat/push-notifications-UI branch from 6595a6f to 36e11d6 Compare January 27, 2026 09:37
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just got some questions, mainly regarding the onboarding and privacy mode

@alexjba alexjba force-pushed the feat/push-notifications-UI branch from 36e11d6 to b7a5126 Compare January 30, 2026 13:49
@alexjba alexjba requested a review from caybro January 30, 2026 13:58
Adding the possibility for the user to interact with the OS push notification permissions.

1. Adding a `EnablePushNotificationsPopup` component. This component will be shown at start-up. The user can use it to request push notifications permissions or to navigate to OS settings if the permissions cannot be enabled from within the app
2. Hook the push notifications permissions to NotificationsView. The `Enable push notifications` toggle will also ask for push notifications permissions if possible. Otherwise it will show an additional section guiding the user to enable push notifications from OS settings.
@alexjba alexjba force-pushed the feat/push-notifications-UI branch from b7a5126 to 65a4f9c Compare February 2, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mobile] Implement Push notification logic and UI screens

3 participants