Skip to content

test(e2e-mobile): Add wallet account rename#19795

Merged
glitchminer merged 1 commit intomasterfrom
test/e2e-mobile-account-rename
Feb 2, 2026
Merged

test(e2e-mobile): Add wallet account rename#19795
glitchminer merged 1 commit intomasterfrom
test/e2e-mobile-account-rename

Conversation

@glitchminer
Copy link
Contributor

@glitchminer glitchminer commented Jan 26, 2026

Summary

  • Add ACCOUNT_MENU_EDIT locator for Edit context menu action
  • Add edit_account_via_menu() method to WalletLeftPanel
  • Add _clear_input_field() to BasePage for Qt/QML input clearing
  • Extend test_add_and_delete_generated_account with rename verification
  • Make ADD_ACCOUNT_PRIMARY locator flexible for both "Add account" and "Save changes" button text

Test Flow

The extended test now covers the complete account lifecycle:

  1. Add account - Creates a new generated account via modal
  2. Verify added - Confirms success toast and account count increased
  3. Rename account - Long-press → Edit → Clear existing name → Enter new name → Save (NEW)
  4. Verify renamed - Confirms new name appears in account list (NEW)
  5. Delete account - Long-press → Delete → Confirm → Authenticate
  6. Verify deleted - Confirms removal toast and account count decreased

Test plan

  • Test passes on BrowserStack Android
video-0b5ccaf85c948179363c47546f17a1b8312e9fc8.mp4

Closes #19776

@glitchminer glitchminer self-assigned this Jan 26, 2026
@glitchminer glitchminer requested a review from a team as a code owner January 26, 2026 18:17
@status-im-auto
Copy link
Member

status-im-auto commented Jan 26, 2026

Jenkins Builds

Click to see older builds (37)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a280ce0 1 2026-01-26 18:28:49 ~10 min ios/aarch64 📱ipa 📲
✔️ a280ce0 1 2026-01-26 18:30:34 ~12 min tests/nim 📄log
✔️ a280ce0 1 2026-01-26 18:31:45 ~13 min tests/ui 📄log
a280ce0 1 2026-01-26 18:35:00 ~17 min macos/aarch64-nwaku 📄log
✔️ a280ce0 1 2026-01-26 18:35:40 ~17 min macos/aarch64 🍎dmg
✖️ a280ce0 PR19795 2026-01-26 18:36:12 ~6 min tests/e2e-android 📦pkg
✔️ a280ce0 1 2026-01-26 18:39:59 ~22 min linux/x86_64 📦tgz
✔️ a280ce0 1 2026-01-26 18:40:08 ~22 min linux/x86_64-nwaku 📦tgz
✔️ a280ce0 1 2026-01-26 18:59:04 ~41 min windows/x86_64 💿exe
✔️ a280ce0 9388 2026-01-26 19:01:20 ~21 min tests/e2e 📊rpt
✔️ a280ce0 1559 2026-01-26 19:27:14 ~28 min tests/e2e-windows 📊rpt
✖️ a280ce0 PR19795 2026-01-28 05:53:13 ~23 min tests/e2e-android 📦pkg
✖️ a280ce0 PR19795 2026-01-29 05:52:44 ~21 min tests/e2e-android 📦pkg
a280ce0 2 2026-01-29 22:54:09 ~19 min linux/x86_64 📄log
✖️ a280ce0 PR19795 2026-01-30 06:02:02 ~30 min tests/e2e-android 📦pkg
✔️ c4cf8d99 1 2026-01-26 18:29:08 ~11 min android/arm64 🤖apk 📲
✔️ 76bd3b2a 2 2026-01-28 05:29:35 ~11 min android/arm64 🤖apk 📲
✔️ 77c55d7d 3 2026-01-29 05:31:21 ~12 min android/arm64 🤖apk 📲
✔️ 5edc2d2b 4 2026-01-30 05:31:18 ~12 min android/arm64 🤖apk 📲
✔️ 2b17c84 5 2026-01-30 11:20:04 ~9 min android/arm64 🤖apk 📲
✔️ 2b17c84 2 2026-01-30 11:20:27 ~10 min tests/nim 📄log
✖️ 2b17c84 PR19795 2026-01-30 11:25:37 ~5 min tests/e2e-android 📦pkg
✔️ 2b17c84 2 2026-01-30 11:26:51 ~16 min tests/ui 📄log
✔️ 2b17c84 2 2026-01-30 11:28:17 ~18 min ios/aarch64 📱ipa 📲
✔️ 2b17c84 3 2026-01-30 11:30:19 ~20 min linux/x86_64 📦tgz
✔️ 2b17c84 2 2026-01-30 11:30:48 ~20 min linux/x86_64-nwaku 📦tgz
✔️ 2b17c84 2 2026-01-30 11:34:13 ~23 min macos/aarch64 🍎dmg
✔️ 2b17c84 2 2026-01-30 11:34:33 ~24 min macos/aarch64-nwaku 🍎dmg
2b17c84 9473 2026-01-30 11:48:04 ~17 min tests/e2e 📄log
✔️ 2b17c84 2 2026-01-30 11:52:48 ~42 min windows/x86_64 💿exe
✖️ 2b17c84 1609 2026-01-30 12:17:04 ~24 min tests/e2e-windows 📊rpt
✔️ 2b17c84 4 2026-01-30 15:36:38 ~20 min linux/x86_64 📦tgz
✔️ 2b17c84 9488 2026-01-30 15:54:24 ~17 min tests/e2e 📊rpt
✖️ 2b17c84 PR19795 2026-01-31 06:08:27 ~28 min tests/e2e-android 📦pkg
✖️ 2b17c84 PR19795 2026-02-02 06:23:12 ~42 min tests/e2e-android 📦pkg
✔️ 5c0ffb8f 6 2026-01-31 05:40:16 ~21 min android/arm64 🤖apk 📲
✔️ c8dba09a 7 2026-02-02 05:40:07 ~21 min android/arm64 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5459ad4 8 2026-02-02 11:42:53 ~10 min android/arm64 🤖apk 📲
✔️ 5459ad4 3 2026-02-02 11:44:08 ~11 min tests/nim 📄log
✖️ 5459ad4 506 2026-02-02 11:48:33 ~5 min tests/e2e-android 📦pkg
✔️ 5459ad4 3 2026-02-02 11:49:39 ~17 min tests/ui 📄log
✔️ 5459ad4 3 2026-02-02 11:52:03 ~19 min macos/aarch64-nwaku 🍎dmg
✔️ 5459ad4 3 2026-02-02 11:52:05 ~19 min macos/aarch64 🍎dmg
✔️ 5459ad4 3 2026-02-02 11:53:01 ~20 min ios/aarch64 📱ipa 📲
✔️ 5459ad4 5 2026-02-02 11:53:57 ~21 min linux/x86_64 📦tgz
✔️ 5459ad4 3 2026-02-02 11:54:11 ~21 min linux/x86_64-nwaku 📦tgz
✔️ 5459ad4 9522 2026-02-02 12:11:36 ~17 min tests/e2e 📊rpt
✔️ 5459ad4 3 2026-02-02 12:14:23 ~41 min windows/x86_64 💿exe
✔️ 5459ad4 1643 2026-02-02 12:43:55 ~29 min tests/e2e-windows 📊rpt

if name:
names.append(name)
except Exception as e:
self.logger.debug(f"Failed to extract account name: {e}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we dont raise the expection but silence it to logger ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, it's just to avoid some flakiness for the time being. I didn't want to mark the whole thing expected fail while other more critical parts can still be checked.

@glitchminer glitchminer force-pushed the test/e2e-mobile-account-rename branch from a280ce0 to 2b17c84 Compare January 30, 2026 11:09
@glitchminer glitchminer force-pushed the test/e2e-mobile-account-rename branch from 2b17c84 to 5459ad4 Compare February 2, 2026 11:32
@glitchminer glitchminer merged commit aef84b8 into master Feb 2, 2026
13 of 14 checks passed
@glitchminer glitchminer deleted the test/e2e-mobile-account-rename branch February 2, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(e2e-mobile): add account edit/rename flow to wallet test

4 participants