test(e2e-mobile): Add app restart verification to wallet test#19802
Merged
glitchminer merged 1 commit intomasterfrom Feb 2, 2026
Merged
test(e2e-mobile): Add app restart verification to wallet test#19802glitchminer merged 1 commit intomasterfrom
glitchminer merged 1 commit intomasterfrom
Conversation
7 tasks
Member
Jenkins BuildsClick to see older builds (28)
|
anastasiyaig
approved these changes
Jan 27, 2026
alexjba
approved these changes
Jan 29, 2026
| return False | ||
|
|
||
| auth_modal = KeycardAuthenticationModal(self.driver) | ||
| if auth_modal.is_displayed(timeout=3): |
Contributor
There was a problem hiding this comment.
would it be a good idea to extract the timeouts as constants in a file? Right now the timeouts seem random to me.
The reasoning being that maybe these timeouts could be used in the future to lock in place perf improvements. Even squish is not there yet, but at last we'll have an easier job. Ideally all timeouts except for the login should be way under 1 sec (I know it's far fetched now).
Contributor
Author
There was a problem hiding this comment.
agree, will create a task to review this across the other pages as well.
glitchminer
force-pushed
the
test/e2e-mobile-account-rename
branch
from
a280ce0 to
2b17c84
Compare
glitchminer
force-pushed
the
test/e2e-mobile-account-restart
branch
from
ac1ddd6 to
fc197b9
Compare
glitchminer
force-pushed
the
test/e2e-mobile-account-rename
branch
from
2b17c84 to
5459ad4
Compare
glitchminer
force-pushed
the
test/e2e-mobile-account-restart
branch
from
fc197b9 to
12b99a1
Compare
noeliaSD
approved these changes
Feb 2, 2026
| toast = app.wait_for_toast( | ||
| expected_substring="successfully added", | ||
| timeout=8, | ||
| stability=0.2, |
Contributor
Author
There was a problem hiding this comment.
Method checks for a toast appearing within a certain timeframe.
In some cases it was noted that a toast appeared and disappeared too quickly for the text to be checked so a time is added to make sure the toast is still present and avoid an unnecessary fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_account_element_by_name()method to locate account by name (more robust than index-based selection)delete_account_by_name()method to delete specific account by name_complete_account_deletion()helperTest Flow
The extended test now covers:
Test plan
video-9534e68eae2eba44683eaa08fcd6ba62b41394eb.mp4
Closes #19777