feat(qr): support scanning walletconnect codes #19815
Open
+37
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Member
Jenkins BuildsClick to see older builds (31)
|
1 task
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
83aa0ed to
a70b581
Compare
jrainville
force-pushed
the
feat/support-wc-codes
branch
from
9ec8d9c to
e7de8a1
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
4 times, most recently
from
76ce2f9 to
f2b136b
Compare
jrainville
force-pushed
the
feat/support-wc-codes
branch
from
e7de8a1 to
1b958c2
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
3 times, most recently
from
fb4106c to
7dae4da
Compare
jrainville
force-pushed
the
feat/support-wc-codes
branch
from
1b958c2 to
904213c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Part of #19678
Based on top of #19811
Adds the QML code needed to connect a Dapp using a WalletConnect QR code
Affected areas
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
wc-connect.webm
(I didn't press accept because there is an issue where it crashes the app)
Impact on end user
Makes it possible to connect to WalletConnect using a QR code
How to test
Risk
Low