Draft
Conversation
Member
Jenkins BuildsClick to see older builds (23)
|
On IOS we're free to compile nim-sds as a nim module nim_status_client, nim-sds and status-go are all static libs. With this approach we're fixing the duplicate symbols from both nim runtimes (nim_status_client and nim-sds). We're free to re-enable `lto` without crashing the app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do
On IOS we're free to compile nim-sds as a nim module nim_status_client, nim-sds and status-go are all static libs.
With this approach we're fixing the duplicate symbols from both nim runtimes (nim_status_client and nim-sds). We're free to re-enable
ltowithout crashing the appNeeds:
status-im/status-go#7315
logos-messaging/nim-sds#48
Affected areas
IOS build