feat/issue-18186: Moving Activity Center to the main navigation bar + notification components updates
#18532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (93)
|
noeliaSD
force-pushed
the
feat/issue-18186
branch
from
dd556fd to
ef62ffb
Compare
|
Pushed rebase! |
|
i am looking at autotests for this PR , will commit fixes when ready |
Screen.Recording.2025-08-08.at.14.54.32.mov
3. Icon missing on this page but see it in the small view?
4. The alignment of contact is weird, if this is an existing issue or something you don't want to tackle right now, ignore it
|
mmmm, I'm on mac os, and you? Screen.Recording.2025-08-08.at.15.01.35.mov |
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityBanUnban.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityBanUnban.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityBanUnban.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityBanUnban.qml
Outdated
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityBanUnban.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityKicked.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityMembershipRequest.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityMembershipRequest.qml
Outdated
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/helpers/ActivityCenterTypes.qml
Outdated
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationUnknownGroupChatInvitation.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityShareAddresses.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationContactRequest.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationNewsMessage.qml
Show resolved
Hide resolved
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationBase.qml
Outdated
Show resolved
Hide resolved
me as well, just checkout master and its there |
Reminder: This is just a first step and not the final solution. Here we are only moving from popup to a new section. With the design team we are working on improving navigation, user notifications interaction, actions, etc. There's still a lot more work to do in here.
Screen.Recording.2025-09-02.at.14.06.02.movSaid that, of course, we can improve it. Noted to work on it on next step.
Noted — we’ll address this in the next iteration. This is essentially a navigation and interaction design issue, and I agree it should be prioritized for improvement.
Indeed it was placed completely wrongly. Thanks! Screen.Recording.2025-09-02.at.15.53.18.mov
Posted answer here: #18532 (comment)
Solved
Solved |
|
@micieslak @Khushboo-dev-cpp @anastasiyaig I’ve pushed updates addressing your comments, suggestions, and the issues you raised, keeping the changes aligned with the scope of this PR. Please give it another try and let me know! |
noeliaSD
force-pushed
the
feat/issue-18186
branch
from
b129ffb to
705c2cc
Compare
noeliaSD
requested review from
Khushboo-dev-cpp,
glitchminer,
micieslak and
anastasiyaig
and removed request for
a team and
glitchminer
anastasiyaig
approved these changes
Sep 2, 2025
jrainville
reviewed
Sep 3, 2025
Khushboo-dev-cpp
approved these changes
Sep 4, 2025
caybro
reviewed
Sep 4, 2025
ui/app/AppLayouts/ActivityCenter/controls/NotificationBaseHeaderRow.qml
Outdated
Show resolved
Hide resolved
| background: Rectangle { | ||
| id: backgroundItem | ||
| radius: 6 | ||
| color: mouse.containsMouse ? Theme.palette.primaryColor3 : Theme.palette.transparent |
There was a problem hiding this comment.
Does this work? I've seen a lot of issues with MouseAreas inside background under Qt6
There was a problem hiding this comment.
Mmm, yes.. It works as I explain in here: #18532 (comment)
We need to redo the base notification with the new design and we can take care of the hover as well there. Which type of issues have you spotted under Qt6?
There was a problem hiding this comment.
Nothing particular, just this MouseArea inside the background pattern
ui/app/AppLayouts/ActivityCenter/views/ActivityNotificationCommunityMembershipRequest.qml
Show resolved
Hide resolved
- Applied requested review changes - Refactored code for clarity - Minor improvements to consistency and readability
noeliaSD
force-pushed
the
feat/issue-18186
branch
from
705c2cc to
4aa8106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18186
What does the PR do
This PR introduces a refactor of the
Activity Center, transitioning it from a popup-based component to a layout-based component. In parallel, it includes improvements tonotification componentsand a small feature enhancement toStatusBetaTag.📝 NOTE for the reviewer
Key Changes
Refactor: Activity Center Architecture
Moved
ActivityCenterdirectory toAppLayoutsThis prepares for its transformation into a layout-based section, reflecting its new architectural role.
No functional or visual changes introduced at this stage.
Converted
Activity Centerfrom popup to layoutStatusActivityCenterButton, related signals, properties, and logic across layouts.Decoupled internal dependencies
Chat.RootStorefromActivityCenterNotifications.ActivityCenterStoredependency from individual notification components.Centralized state management
ActivityCenterStoreinstantiation to the root store.ActivityCenterStoreto a new root-level directory to reflect its global, cross-domain nature.UI & Storybook Improvements
Activity Center notificationdelegates.Storybook integrationwith new interactive controls for easier testing.Architecture Benefits
Affected areas
The complete
Activity Centerfeature and related flowsArchitecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Screen.Recording.2025-08-07.at.22.42.02.mov
Screen.Recording.2025-08-07.at.23.01.50.mov
Impact on end user
The location and user experience of the
Activity Center notificationswill change, as they are now integrated into the main navigation bar rather than displayed as a popup.How to test
Risk
There is a moderate risk of introducing regressions across the
Activity Center notification feature, particularly in terms of UI consistency and behavior.