chore(wallet): Marking the heavy model transformation by commenting or removing the code #18563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r removing the code This is the first step for the perf analysis. The removed code needs to be inspected piece by piece to pinpoint the expensive calls and propose a new solution
Jenkins Builds
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
WIP - do not merge
fcc98cc - Removing the expensive flows so that it can be analyzed in small pieces. The next step is to bring back each feature one by one without affecting performance. The improvements I'm getting without these flows are amazing. On my heavy accounts it used to take me close 1 minute to open wallet and then open collectibles. Now it's instant.
Affected areas
Wallet - assets
Wallet - collectibles
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Impact on end user
How to test
Risk