feat(@desktop/wallet): Adding UI flows for Enabling/Disabling Third #18684

Khushboo-dev-cpp · 2025-08-21T14:36:09Z

party services

What does the PR do

Summary
This PR introduces the Third-Party Services feature with full UI integration, feature-flag control, and persistence in the settings database.

Key Changes

UI Flows
Added Third-Party Services section on the Welcome Page.
Added Third-Party Services option in the Privacy & Settings view.
Feature Flag
Introduced privacyModeFeatureEnabled flag to toggle the feature on/off.
Settings Database
Added a new setting in the Go settings DB to persist user preference.
Integrated with UI switch to enable/disable the feature.
Onboarding Integration
Integrated Third-Party Services setting into the account creation/login flows.

Covered Flows

CreateProfileWithPassword
CreateProfileWithSeedphrase
CreateProfileWithKeycardNewSeedphrase
CreateProfileWithKeycardExistingSeedphrase
LoginWithSeedphrase
LoginWithSyncing
LoginWithKeycard

Notes
The feature is disabled by default and controlled via the feature flag.
When enabled, users can opt-in/out through the UI switch, and the setting is saved in the DB on go side

Affected areas

Architecture compliance

I am familiar with the application architecture and agreed good practices.
My PR is consistent with this document: QML Architecture Guidelines

Screencapture of the functionality

Screen.Recording.2025-08-28.at.13.59.09.mov

Impact on end user

How to test

Risk

status-im-auto · 2025-08-21T14:39:16Z

Jenkins Builds

Click to see older builds (26)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`1dedc99`	#1	2025-08-21 14:39:16	~2 min	`macos/aarch64`	📄`log`
❌	`1dedc99`	#1	2025-08-21 14:39:16	~2 min	`macos/aarch64-nwaku`	📄`log`

✔️	`0d77bf4`	#4	2025-08-28 07:45:36	~6 min	`tests/nim`	📄`log`
❌	`0d77bf4`	#4	2025-08-28 07:50:39	~11 min	`tests/ui`	📄`log`
✔️	`0d77bf4`	#4	2025-08-28 07:55:20	~15 min	`linux/x86_64`	📦`tgz`
✔️	`0d77bf4`	#4	2025-08-28 08:01:06	~21 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`0d77bf4`	pr18684	2025-08-28 08:06:29	~11 min	`tests/e2e`	📊`rpt`
✔️	`0d77bf4`	#4	2025-08-28 08:07:28	~27 min	`windows/x86_64`	💿`exe`

✔️	`fd95753`	#5	2025-08-28 09:29:53	~6 min	`tests/nim`	📄`log`
❌	`fd95753`	#5	2025-08-28 09:34:36	~11 min	`tests/ui`	📄`log`
✔️	`fd95753`	#5	2025-08-28 09:38:29	~14 min	`linux/x86_64`	📦`tgz`
✔️	`fd95753`	#5	2025-08-28 09:45:57	~22 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`fd95753`	#5	2025-08-28 09:46:58	~23 min	`windows/x86_64`	💿`exe`
✔️	`fd95753`	pr18684	2025-08-28 09:49:29	~10 min	`tests/e2e`	📊`rpt`
✔️	`fd95753`	#6	2025-08-28 10:15:32	~12 min	`macos/aarch64`	🍎`dmg`
✔️	`fd95753`	#6	2025-08-28 10:20:03	~16 min	`macos/aarch64-nwaku`	🍎`dmg`

✔️	`775b3d7`	#7	2025-08-28 11:58:10	~5 min	`tests/nim`	📄`log`
✔️	`775b3d7`	#7	2025-08-28 12:04:58	~12 min	`tests/ui`	📄`log`

✔️	`83750de`	#8	2025-08-28 12:27:31	~6 min	`tests/nim`	📄`log`
✔️	`83750de`	#8	2025-08-28 12:34:29	~13 min	`tests/ui`	📄`log`
✔️	`83750de`	#9	2025-08-28 12:37:53	~16 min	`linux/x86_64`	📦`tgz`
✔️	`83750de`	#10	2025-08-28 12:39:49	~18 min	`macos/aarch64-nwaku`	🍎`dmg`
✔️	`83750de`	#11	2025-08-28 12:40:46	~11 min	`macos/aarch64`	🍎`dmg`
✔️	`83750de`	pr18684	2025-08-28 12:48:46	~10 min	`tests/e2e`	📊`rpt`
✔️	`83750de`	#8	2025-08-28 12:49:28	~28 min	`windows/x86_64`	💿`exe`
✔️	`83750de`	#10	2025-08-28 12:50:01	~20 min	`linux/x86_64-nwaku`	📦`tgz`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`255167b`	#9	2025-08-28 15:49:15	~5 min	`tests/nim`	📄`log`
✔️	`255167b`	#9	2025-08-28 15:55:58	~12 min	`tests/ui`	📄`log`
✔️	`255167b`	#9	2025-08-28 16:10:35	~27 min	`windows/x86_64`	💿`exe`

✔️	`6171b2b`	#10	2025-08-29 12:57:03	~7 min	`tests/nim`	📄`log`
✔️	`6171b2b`	#10	2025-08-29 13:02:46	~13 min	`tests/ui`	📄`log`
✔️	`6171b2b`	#12	2025-08-29 13:12:11	~22 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`6171b2b`	#10	2025-08-29 13:15:33	~26 min	`windows/x86_64`	💿`exe`

party services fixes #18510

caybro

Looks good in general! Just some small objections

caybro · 2025-09-03T19:24:26Z

storybook/qmlTests/tests/tst_OnboardingLayout.qml

+            // Verify visibility
+            tryCompare(thirdPartyServices, "visible", true)
+
+            waitForRendering(page)


Why wait here and then not check anything? 😄

caybro · 2025-09-03T19:24:44Z

ui/app/AppLayouts/Onboarding2/OnboardingFlow.qml

@@ -64,6 +67,11 @@ OnboardingStackView {

    signal finished(int flow)

+    // Thirdparty services
+    property bool privacyModeFeatureEnabled
+    property bool thirdpartyServicesEnabled


make them required please

caybro · 2025-09-03T19:25:51Z

ui/app/AppLayouts/Profile/views/PrivacyAndSecurityView.qml


 SettingsContentBase {
    id: root

    property bool isStatusNewsViaRSSEnabled
    required property bool isCentralizedMetricsEnabled
+    property bool thirdpartyServicesEnabled
+    property bool privacyModeFeatureEnabled


caybro · 2025-09-03T19:27:40Z

ui/imports/shared/popups/ThirdpartyServicesPopup.qml

+
+import utils
+
+StatusModal {


StatusDialog in new code pls

caybro · 2025-09-03T19:28:28Z

ui/imports/shared/popups/ThirdpartyServicesPopup.qml

+                    anchors.right: parent.right
+                    anchors.rightMargin: Theme.padding
+                    anchors.leftMargin: Theme.padding
+                    anchors.topMargin: Theme.padding


Yay anchors 🫢

caybro · 2025-09-03T19:29:19Z

ui/imports/shared/popups/ThirdpartyServicesPopup.qml

+    rightButtons: [
+        StatusButton {
+            type: StatusBaseButton.Type.Primary
+            normalColor: Theme.palette.customisationColors.purple


As elsewhere, purple on purpose?

caybro · 2025-09-03T19:30:26Z

ui/imports/utils/Constants.qml

@@ -1012,6 +1012,8 @@ QtObject {
    readonly property string statusHelpLinkPrefix: `https://status.app/help/`
    readonly property string downloadLink: "https://status.im/get"
    readonly property string sendViaChatPrefix: '//send-via-personal-chat//'
+    readonly property string statusDiscussPageUrl: 'https://discuss.status.app/c/features/51'


statusDiscussPageUrl sounds like a generic page, eventhough it points to a very specific one (Feature requests)

noeliaSD

Here some comments added:

Issues found while testing:

The toggle doesn't work properly since we need a "doble-confirmation". I think the toggle should be reevaluated after closing the popup so that it really takes the real state. Here the video:

Screen.Recording.2025-09-05.at.13.22.25.mov

Design questions:

The only way to enable or disable privacy mode during the onboarding process is with a new fresh account. If I'm already logged in with an account, even if I create a new one, the page / flow won't be accessible. Perhaps we should consider other onboarding flows as well. WDYT @Khushboo-dev-cpp @xAlisher?

noeliaSD · 2025-09-05T11:37:34Z

storybook/pages/PrivacyAndSecurityViewPage.qml

+            thirdpartyServicesEnabled: ctrlThirdpartyServicesEnabled.checked
+            privacyModeFeatureEnabled: ctrlPrivacyMode.checked
+            onOpenThirdpartyServicesInfoPopupRequested: {
+                console.warn("onLaunchThirdyPartyServicesInfoPopupRequested")


Suggestion: You could use the log mechanism we normally use inside storybook so that the log is already visible inside the same environment!

noeliaSD · 2025-09-05T11:38:32Z

storybook/pages/ThirdpartyServicesPopupPage.qml

+            visible: true
+            closePolicy: Popup.CloseOnEscape
+            thirdPartyServicesEnabled: ctrlThirdpartyServicesEnabled.checked
+            onToggleThirdpartyServicesEnabled: console.warn("onToggleThirdpartyServicesEnabled called ")


noeliaSD · 2025-09-05T11:40:05Z

ui/app/AppLayouts/Onboarding2/OnboardingFlow.qml

@@ -64,6 +67,11 @@ OnboardingStackView {

    signal finished(int flow)

+    // Thirdparty services
+    property bool privacyModeFeatureEnabled


Is this a wip one, right? Maybe a comment to understand that this will be removed once we remove the feature flag would help!

noeliaSD · 2025-09-05T11:40:41Z

ui/app/AppLayouts/Onboarding2/OnboardingFlow.qml

+    // Thirdparty services
+    property bool privacyModeFeatureEnabled
+    property bool thirdpartyServicesEnabled
+    signal toggleThirdpartyServicesEnabled()


suggestion: We are trying to unify nomenclarture

Suggested change

signal toggleThirdpartyServicesEnabled()

signal toggleThirdpartyServicesEnabledRequested()

noeliaSD · 2025-09-05T11:42:16Z

ui/app/AppLayouts/Onboarding2/pages/WelcomePage.qml

@@ -15,13 +15,15 @@ import utils
 OnboardingPage {
    id: root

-    title: qsTr("Welcome to Status")
+    property bool privacyModeFeatureEnabled
+    property bool thirdpartyServicesEnabled


Suggested change

property bool thirdpartyServicesEnabled

required property bool thirdpartyServicesEnabled

noeliaSD · 2025-09-05T11:44:11Z

ui/app/AppLayouts/Profile/stores/PrivacyStore.qml

@@ -44,4 +44,12 @@ QtObject {
    function mnemonicWasShown() {
        root.privacyModule.mnemonicWasShown()
    }
+
+    readonly property bool thirdpartyServicesEnabled: appSettings.thirdpartyServicesEnabled


It would be nice if we access to the appSettings context property via an instance here

Seeing now this property in here, I think that there is a bit of messed up nomenclature with this other property from the comment here? #18750 (comment)

noeliaSD · 2025-09-05T11:51:12Z

ui/app/AppLayouts/Profile/views/PrivacyAndSecurityView.qml

+            subTitle: qsTr("Enable/disable all third-party services")
+            components: [
+                StatusSwitch {
+                    checked: root.thirdpartyServicesEnabled


Already written in the global comments.. There's a double-check action needed, so that, there's a middle state a bit confusing

Khushboo-dev-cpp force-pushed the feat/toggleThirdPartyServices branch 5 times, most recently from fd95753 to f35d360 Compare August 28, 2025 11:48

Khushboo-dev-cpp marked this pull request as ready for review August 28, 2025 11:48

Khushboo-dev-cpp requested review from micieslak, caybro, alexjba, noeliaSD and a team as code owners August 28, 2025 11:48

Khushboo-dev-cpp force-pushed the feat/toggleThirdPartyServices branch 3 times, most recently from 83750de to 255167b Compare August 28, 2025 15:43

feat(@desktop/wallet): Adding UI flows for Enabling/Disabling Third

6171b2b

party services fixes #18510

Khushboo-dev-cpp force-pushed the feat/toggleThirdPartyServices branch from 255167b to 6171b2b Compare August 29, 2025 12:49

dlipicar approved these changes Sep 3, 2025

View reviewed changes

caybro reviewed Sep 3, 2025

View reviewed changes

noeliaSD reviewed Sep 5, 2025

View reviewed changes

	signal toggleThirdpartyServicesEnabled()
	signal toggleThirdpartyServicesEnabledRequested()

	property bool thirdpartyServicesEnabled
	required property bool thirdpartyServicesEnabled

feat(@desktop/wallet): Adding UI flows for Enabling/Disabling Third #18684

Are you sure you want to change the base?

feat(@desktop/wallet): Adding UI flows for Enabling/Disabling Third #18684

Uh oh!

Conversation

Khushboo-dev-cpp commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does the PR do

Affected areas

Architecture compliance

Screencapture of the functionality

Impact on end user

How to test

Risk

Uh oh!

status-im-auto commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jenkins Builds

Uh oh!

caybro left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

noeliaSD left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Khushboo-dev-cpp commented Aug 21, 2025 •

edited

Loading

status-im-auto commented Aug 21, 2025 •

edited

Loading