Proper close/hide behavior on mac #18739
Open
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micieslak
requested review from
caybro,
alexjba,
noeliaSD and
a team
as code owners
Jenkins Builds
|
jrainville
approved these changes
Aug 28, 2025
caybro
reviewed
Sep 1, 2025
| */ | ||
| Connections { | ||
| target: SystemUtils | ||
| enabled: SQUtils.Utils.mac |
There was a problem hiding this comment.
I personally wouldn't do this distinction here (macOS vs. other); we know we want this behavior everywhere
noeliaSD
reviewed
Sep 4, 2025
There was a problem hiding this comment.
Tested and there's an scenario that I was not expecting unless I'm missing something..
Whenever the app is running after onboarding, clicking X minimizes the app instead of closing it. Instead, during the onboarding, it does quit correctly.
Screen.Recording.2025-09-04.at.14.27.52.mov
The rest of scenarios are working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
This PR introduces workaround to handle closing behavior on mac in a desired way.
minimize on close enabled:
minimize on close disabled:
Closes: #18667
Affected areas
SystemUtilsInternal,main.qmlArchitecture compliance
My PR is consistent with this document: QML Architecture Guidelines
How to test
Try scenarios listed above.
Risk
Low