Skip to content

feat: more descriptive local notification preview text#7389

Open
alexjba wants to merge 1 commit intodevelopfrom
fix/more-descriptive-local-notification
Open

feat: more descriptive local notification preview text#7389
alexjba wants to merge 1 commit intodevelopfrom
fix/more-descriptive-local-notification

Conversation

@alexjba
Copy link
Contributor

@alexjba alexjba commented Mar 27, 2026

Add getMessagePreviewText helper that uses GetSimplifiedText to produce notification-safe previews: strips markdown, resolves mention display names, and falls back to raw text.

Iterates status-im/status-app#19532

Add getMessagePreviewText helper that uses GetSimplifiedText to produce
notification-safe previews: strips markdown, resolves mention display
names, and falls back to raw text.
@github-actions
Copy link

⚠️ Companion PR Required

Add a link to your status-app PR in this PR's description.

Example: https://github.com/status-im/status-app/pull/123

@status-im-auto
Copy link
Member

status-im-auto commented Mar 27, 2026

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 135fad0 1 2026-03-27 15:22:16 ~3 min linux/status-go 📦zip
✔️ 135fad0 1 2026-03-27 15:24:03 ~5 min windows/status-go 📦zip
✔️ 135fad0 1 2026-03-27 15:25:44 ~7 min macos/status-go 📦zip
✔️ 135fad0 1 2026-03-27 15:34:36 ~16 min tests-rpc 📄log
✔️ 135fad0 1 2026-03-27 15:53:39 ~35 min tests 📄log

@codecov
Copy link

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.06%. Comparing base (eba6399) to head (135fad0).

Files with missing lines Patch % Lines
protocol/local_notifications.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7389      +/-   ##
===========================================
- Coverage    61.42%   61.06%   -0.36%     
===========================================
  Files          822      822              
  Lines       116115   115748     -367     
===========================================
- Hits         71319    70684     -635     
- Misses       37510    37788     +278     
+ Partials      7286     7276      -10     
Flag Coverage Δ
functional 39.60% <64.00%> (-0.84%) ⬇️
unit 55.26% <88.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/local_notifications.go 88.82% <88.00%> (+0.57%) ⬆️

... and 54 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants