Update send summary to show network in a separate card (#21616) #22067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (43)
|
alwx
requested review from
briansztamfater,
flexsurfer,
shivekkhurana and
smohamedjavid
flexsurfer
approved these changes
Feb 17, 2025
|
It would be very helpful to add a proper description and include some screenshots to quickly identify the visual and non-visual changes in this PR. |
|
Moreover, it is a requirement for proceeding PRs, thanks @briansztamfater |
64% of end-end tests have passedFailed tests (4)Click to expandClass TestWalletOneDevice:
Class TestWalletMultipleDevice:
Passed tests (7)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
|
|
hi. thank you for PR. Should "..." and cotract address showing be included into current PR? Currently it doesnt Actual result:
Expected result:
https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=18081-106910&m=dev |
|
@VolodLytvynenko I don't think we currently have any way to get that contact address. Will check it later and come back with more information. |
|
@alwx @shivekkhurana I am posting this as a summary because, based on the design, it seems the template in figma was created specifically for the asset sending flow. However, other flows are also affected. Here are some examples: 1 CollectiblesPR's Send flow confirmation screen:
Latest Develop:
Notes:From my perspective, there are no inherent drawbacks. |
2 BridgeActual bridge flow confirmation screen:
Latest develop:
Note:
|
|
Hi @alwx, Apologies for the testing delays—I had to switch to a higher-priority PR. I also discussed this PR with the design team here regarding whether the changes should apply to the bridge and collectibles confirmation screens. So far, @pedro-et has confirmed that the bridge shouldn't be modified. Maybe the same should be done with the collectibles confirmation screen, but Pedro didn't replied yet Could you revert bridge tx confirmation screen it to how it was in the latest nightly? ISSUE 1: Brdige confirmation tx screen is wrongSteps:
Actual result:
Expected result:
|
|
I can confirm that this ticket was only for send flow. Bridge should not be affected. |
|
Will update bridge before lunch today (was busy with this: #22179) |
|
@VolodLytvynenko ready! |
64% of end-end tests have passedFailed tests (5)Click to expandClass TestWalletCollectibles:
Class TestWalletOneDevice:
Passed tests (9)Click to expandClass TestWalletCollectibles:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
|
|
I’m now transferring this PR to @yevh-berdnyk, who is working on E2E fixes. She will let us know when e2e are ready and after that PR can be merged. |
71% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletCollectibles:
Passed tests (10)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
|
100% of end-end tests have passedPassed tests (4)Click to expandClass TestWalletCollectibles:
Class TestCommunityOneDeviceMerged:
|
|
Hi @alwx, e2e tests are updated, PR can be merged, thanks! |
shivekkhurana
approved these changes
Feb 25, 2025
|
One test is failing: Details
|
|
iOS cannot be build for some reason that has nothing to do with this PR |
|
iOS build issue is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21616
status: ready