feat: preview deploy workflow for external contributors #872
Conversation
🦋 Changeset detectedLatest commit: 84c74ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR adds a new GitHub Actions workflow to enable preview deployments for pull requests from external contributors (forked repositories). The workflow uses pull_request_target with environment-based approval to safely deploy previews while protecting repository secrets.
Key Changes:
- Adds automated preview deployment workflow for fork PRs with manual approval requirement
- Implements Turbo-based change detection to selectively deploy only affected applications
- Creates GitHub commit statuses and PR comments with deployment URLs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/preview-deploy.yml |
New workflow for deploying preview environments for external contributors with approval gate, Turbo change detection, and Vercel deployments for affected apps |
.changeset/thick-humans-impress.md |
Changeset documenting the new preview deploy feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jenkins BuildsClick to see older builds (6)
|
@jinhojang6 No, unfortunately no, this is the tricky part, I can test it after merge. I did some testing with similar workflow with my personal account, but this is company account and is little bit different and needs testing afterwards. |
felicio
left a comment
felicio
left a comment
There was a problem hiding this comment.
Left a couple of comments 👍.
Would also first test it with your own Vercel team with at least one project set up there.
github-project-automation
bot
moved this from In Progress
to Waiting
in Web & User Interfaces
jinhojang6
left a comment
jinhojang6
left a comment
There was a problem hiding this comment.
@jkbktl Thanks, let me double-check after this PR is merged again.
There was a problem hiding this comment.
Overall code looks good to me 👍
I'll test the functionality once merged.
On a side note, we have to be careful when approving "anybody"'s code to be deployed. One could introduce a harmful script or library for example and since we deploy everything with powerful permissions it can be dangerous.
|
I forked the status-web repo and verified the workflow by making a test change and triggering the Vercel preview deployment after approval: #914 Here is a preview example: https://status-website-git-fork-jinhojang6-pr-872-status-im-web.vercel.app/ 
We need to manually authoize each app by clicking the |
5 participants
This PRs:
This needs to be tested after merge.
relates https://github.com/status-im/status-website/issues/1576
to do: