add i18n to apps/hub #892
add i18n to apps/hub #892
Conversation
Co-authored-by: JulesFILIOT <dev@julesfiliot.com>
🦋 Changeset detectedLatest commit: 0c39404 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
Signed-off-by: yjkellyjoo <yejinkellyjoo@gmail.com>
Signed-off-by: yjkellyjoo <yejinkellyjoo@gmail.com>
This reverts commit 5bbd784.
revert logos
Add internationalization support to the status.network feature.
There was a problem hiding this comment.
Pull request overview
This pull request adds internationalization (i18n) support to the apps/hub application using next-intl, introducing support for English and Korean languages. The changes include middleware setup, routing configuration, translation files, and comprehensive updates to components to use translation keys instead of hardcoded strings.
Changes:
- Added next-intl and related i18n dependencies with middleware configuration
- Created translation infrastructure (routing, request handling, navigation helpers, locale mapping)
- Added comprehensive English and Korean translation files with 1091+ translation keys
- Updated all components, pages, and layouts to use translation hooks and keys
Reviewed changes
Copilot reviewed 79 out of 80 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Added i18n dependencies: next-intl, @formatjs/intl-localematcher, negotiator, @radix-ui/react-select |
| apps/hub/next.config.ts | Integrated next-intl plugin for i18n routing |
| apps/hub/src/middleware.ts | Added i18n middleware for locale detection and routing with hash preservation |
| apps/hub/src/i18n/* | Created i18n infrastructure files for routing, request handling, and navigation |
| apps/hub/messages/*.json | Added comprehensive translation files for English and Korean |
| apps/hub/src/app/layout.tsx | Updated root layout for i18n support with locale-aware HTML lang attribute |
| apps/hub/src/app/[locale]/* | Created locale-based routing structure with layouts and pages |
| apps/hub/src/app/_components/* | Updated all components to use useTranslations hook instead of hardcoded strings |
| apps/hub/src/data/* | Added translation keys (nameKey, descriptionKey) to app data |
| packages/status-network/src/components/* | Exported FeedbackPopoverProps and added Footer labels prop for i18n |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {t('hero.title').includes('on the free network') ? ( | ||
| <> | ||
| Get started <br /> on the free network | ||
| </> | ||
| ) : ( | ||
| t('hero.title') | ||
| )} |
There was a problem hiding this comment.
The hero title handling includes a fallback check for the English text "on the free network" which is brittle. If the translation changes slightly, this logic will break. Consider using a separate translation key for Korean or restructuring the title to avoid this conditional rendering based on string matching.
|
6 participants
based on #889
where