Skip to content

Comments

Added 8-bit and 16-bit int vec types#56

Open
tomc1998 wants to merge 1 commit intostavenko:masterfrom
tomc1998:master
Open

Added 8-bit and 16-bit int vec types#56
tomc1998 wants to merge 1 commit intostavenko:masterfrom
tomc1998:master

Conversation

@tomc1998
Copy link

These are useful for 2d/3d grid based systems, e.g. a position within a minecraft voxel chunk only requires a vec3ui8

Once you've got a couple entities you start to see real cache performance improvements if you're shrinking your vector type by 4x

@krux02
Copy link
Collaborator

krux02 commented Sep 17, 2021

I have to think a bit about this. Generally speaking I totally agree this is useful. I just don't know if I like the names, as they are not consistent with the existing name schema. I like your name schema, but with it, I would need to rename everything. Do you think just exporting the template that generates all the types would be good enough for you?

@tomc1998
Copy link
Author

Do you think just exporting the template that generates all the types would be good enough for you?

Probably not for me personally, i just use my glm fork, i don't want to have to remember which module contains which vector type

what about vec2s/vec2us & vec2b/vec2ub?

@krux02
Copy link
Collaborator

krux02 commented Sep 18, 2021

i just use my glm fork

Yes that is probably a good idea.

what about vec2s/vec2us & vec2b/vec2ub?

I thought about it as well until I realized that vec2b is already a boolean vector.

@tomc1998
Copy link
Author

tomc1998 commented Sep 18, 2021 via email

@krux02
Copy link
Collaborator

krux02 commented Sep 29, 2021

I decided to stay undecided on this. Since you got your solution for your project fast resolution isn't important. If you get other people to agree that this is a good idea, I will go with it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants