Skip to content

Commit 4f5c1aa

Browse files
authored
chore: apply suggestions from code review
Signed-off-by: Philipp Burckhardt <[email protected]>
1 parent 920f098 commit 4f5c1aa

File tree

6 files changed

+11
-23
lines changed

6 files changed

+11
-23
lines changed

lib/node_modules/@stdlib/stats/base/dists/poisson/kurtosis/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,10 @@ for ( i = 0; i < 10; i++ ) {
146146

147147
#### stdlib_base_dists_poisson_kurtosis( lambda )
148148

149-
Evaluates the excess kurtosis of a Poisson distribution.
149+
Returns the [excess kurtosis][kurtosis] of a [Poisson][poisson-distribution] distribution with mean parameter `lambda`.
150150

151151
```c
152-
double out = sstdlib_base_dists_poisson_kurtosis( 9.0 );
152+
double out = stdlib_base_dists_poisson_kurtosis( 9.0 );
153153
// returns ~0.111
154154
```
155155

lib/node_modules/@stdlib/stats/base/dists/poisson/kurtosis/benchmark/benchmark.native.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var Float64Array = require( '@stdlib/array/float64' );
26-
var randu = require( '@stdlib/random/base/randu' );
26+
var uniform = require( '@stdlib/random/base/uniform' );
2727
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2828
var tryRequire = require( '@stdlib/utils/try-require' );
2929
var EPS = require( '@stdlib/constants/float64/eps' );
@@ -49,7 +49,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4949
len = 100;
5050
lambda = new Float64Array( len );
5151
for ( i = 0; i < len; i++ ) {
52-
lambda[ i ] = ( randu() * 20.0 ) + EPS;
52+
lambda[ i ] = uniform( EPS, 20.0 );
5353
}
5454
b.tic();
5555
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/stats/base/dists/poisson/kurtosis/benchmark/c/benchmark.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,18 +93,18 @@ static double random_uniform( const double min, const double max ) {
9393
*/
9494
static double benchmark( void ) {
9595
double elapsed;
96-
double lambda[100];
96+
double lambda[ 100 ];
9797
double y;
9898
double t;
9999
int i;
100100

101101
for ( i = 0; i < 100; i++ ) {
102-
lambda[i] = random_uniform(0.0, 20.0);
102+
lambda[i] = random_uniform( 0.0, 20.0 );
103103
}
104104

105105
t = tic();
106106
for ( i = 0; i < ITERATIONS; i++ ) {
107-
y = stdlib_base_dists_poisson_kurtosis(lambda[i%100]);
107+
y = stdlib_base_dists_poisson_kurtosis( lambda[ i % 100 ] );
108108
if ( y != y ) {
109109
printf( "should not return NaN\n" );
110110
break;

lib/node_modules/@stdlib/stats/base/dists/poisson/kurtosis/include/stdlib/stats/base/dists/poisson/kurtosis.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ extern "C" {
2727
#endif
2828

2929
/**
30-
* Evaluates the excess kurtosis of a Poisson distribution with parameter `lambda`.
30+
* Returns the excess kurtosis of a Poisson distribution with parameter `lambda`.
3131
*/
3232
double stdlib_base_dists_poisson_kurtosis( const double lambda );
3333

lib/node_modules/@stdlib/stats/base/dists/poisson/kurtosis/lib/native.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var addon = require( './../src/addon.node' );
2626
// MAIN //
2727

2828
/**
29-
* Evaluates the the excess kurtosis of a Poisson distribution.
29+
* Returns the excess kurtosis of a Poisson distribution with parameter `lambda`.
3030
*
3131
* @private
3232
* @param {PositiveNumber} lambda - mean parameter

lib/node_modules/@stdlib/stats/base/dists/poisson/kurtosis/src/main.c

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,24 +22,12 @@
2222
/**
2323
* Returns the excess kurtosis of a Poisson distribution with parameter `lambda`.
2424
*
25-
* @param lambda mean parameter of the distribution
26-
* @return excess kurtosis of the Poisson distribution
25+
* @param lambda mean parameter
26+
* @return excess kurtosis
2727
*
2828
* @example
2929
* double y = stdlib_base_dists_poisson_kurtosis( 9.0 );
3030
* // returns ~0.111
31-
*
32-
* @example
33-
* double y = stdlib_base_dists_poisson_kurtosis( 1.0 );
34-
* // returns 1.0
35-
*
36-
* @example
37-
* double y = stdlib_base_dists_poisson_kurtosis( -0.2 );
38-
* // returns NaN
39-
*
40-
* @example
41-
* double y = stdlib_base_dists_poisson_kurtosis( NAN );
42-
* // returns NaN
4331
*/
4432
double stdlib_base_dists_poisson_kurtosis( const double lambda ) {
4533
if (

0 commit comments

Comments
 (0)