Merge branch 'stdlib-js:develop' into random-refactor

Author: saurabhraghuvanshii

.github/workflows/check_contributing_guidelines_acceptance.yml

@@ -43,6 +43,7 @@ on:
     types:
       - opened
       - reopened
+      - edited
 
 # Global permissions:
 permissions:

.github/workflows/lint_pr_title.yml

@@ -26,6 +26,7 @@ on:
       - synchronize
       - opened
       - reopened
+      - edited
 
 # Global permissions:
 permissions:

.github/workflows/lint_random_files.yml

@@ -294,8 +294,12 @@ jobs:
 
       # Lint JavaScript files:
       - name: 'Lint JavaScript files'
+        id: lint-javascript
         if: ( github.event.inputs.javascript != 'false' ) && ( success() || failure() )
         run: |
+          # If any command in a pipeline fails, the entire pipeline should fail:
+          set -o pipefail
+
           # Determine root directory:
           root=$(git rev-parse --show-toplevel)
 
@@ -315,45 +319,81 @@ jobs:
             FIX=0
           fi
 
+          # Combined error file:
+          ERR_FILE="lint_javascript_errors.txt"
+          > "$ERR_FILE"  # Initialize a clean file
+
           # Lint JavaScript source files:
           files=$(echo "${{ steps.random-files.outputs.files }}" | tr ',' '\n' | grep '\.js$' | grep -v -e '/examples' -e '/test' -e '/benchmark' -e '^dist/' | tr '\n' ' ')
 
           # Build native addons if present:
           packages=$(echo "${files}" | tr ' ' '\n' | sed 's/^lib\/node_modules\///g' | sed 's/\/lib\/.*//g' | sort | uniq)
           for pkg in ${packages}; do
-              if [ -f "lib/node_modules/${pkg}/binding.gyp" ]; then
-                  NODE_ADDONS_PATTERN="${pkg}" make install-node-addons
-              fi
+            if [ -f "lib/node_modules/${pkg}/binding.gyp" ]; then
+                NODE_ADDONS_PATTERN="${pkg}" make install-node-addons
+            fi
           done
 
           if [[ -n "${files}" ]]; then
-            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${files}"
+            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${files}" 2>&1 | tee -a "$ERR_FILE"
           fi
 
           # Lint JavaScript command-line interfaces...
           file=$(echo "${{ steps.random-files.outputs.files }}" | tr ',' '\n' | grep '\.js$' | grep -E '/bin/cli$' | tr '\n' ' ')
           if [[ -n "${file}" ]]; then
-            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${file}"
+            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${file}" 2>&1 | tee -a "$ERR_FILE"
           fi
 
           # Lint JavaScript example files:
           files=$(echo "${{ steps.random-files.outputs.files }}" | tr ',' '\n' | grep '/examples/.*\.js$' | tr '\n' ' ')
           if [[ -n "${files}" ]]; then
-            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${files}" ESLINT_CONF="${eslint_examples_conf}"
+            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${files}" ESLINT_CONF="${eslint_examples_conf}" 2>&1 | tee -a "$ERR_FILE"
           fi
 
           # Lint JavaScript test files:
           files=$(echo "${{ steps.random-files.outputs.files }}" | tr ',' '\n' | grep '/test/.*\.js$' | tr '\n' ' ')
           if [[ -n "${files}" ]]; then
-            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${files}" ESLINT_CONF="${eslint_tests_conf}"
+            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${files}" ESLINT_CONF="${eslint_tests_conf}" 2>&1 | tee -a "$ERR_FILE"
           fi
 
           # Lint JavaScript benchmark files:
           files=$(echo "${{ steps.random-files.outputs.files }}" | tr ',' '\n' | grep '/benchmark/.*\.js$' | tr '\n' ' ')
           if [[ -n "${files}" ]]; then
-            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${files}" ESLINT_CONF="${eslint_benchmarks_conf}"
+            make lint-javascript-files FIX="${FIX}" FAST_FAIL=0 FILES="${files}" ESLINT_CONF="${eslint_benchmarks_conf}" 2>&1 | tee -a "$ERR_FILE"
           fi
 
+      # Create sub-issue for JavaScript lint failures:
+      - name: 'Create sub-issue for JavaScript lint failures'
+        if: failure() && contains(steps.lint-javascript.outcome, 'failure')
+        env:
+          GITHUB_TOKEN: ${{ secrets.STDLIB_BOT_PAT_REPO_WRITE }}
+        run: |
+          BODY_FILE="$GITHUB_WORKSPACE/lint_issue_body.md"
+          cat << EOF > "$BODY_FILE"
+          ## JavaScript Linting Failures
+
+          Linting failures were detected in the automated JavaScript lint workflow run.
+
+          ### Workflow Details
+
+          - Run: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+          - Type: JavaScript Linting
+          - Date: $(date -u +"%Y-%m-%d %H:%M:%S UTC")
+
+          ### Error Details
+          \`\`\`
+          $(cat lint_javascript_errors.txt)
+          \`\`\`
+          EOF
+
+          . "$GITHUB_WORKSPACE/.github/workflows/scripts/create_sub_issue" \
+            'Fix JavaScript lint errors' \
+            "$BODY_FILE" \
+            "5377" \
+            "Good First Issue"
+
+          rm "$BODY_FILE"
+
       # Lint Python files:
       - name: 'Lint Python files'
         if: ( github.event.inputs.python != 'false' ) && ( success() || failure() )

.mailmap

@@ -123,6 +123,9 @@ Naresh Jagadeesan <[email protected]> <[email protected].
 
 Naveen Kumar <[email protected]> naveen
 
+Neeraj Pathak <[email protected]> <[email protected]>
+Neeraj Pathak <[email protected]> Neerajpathak07
+
 Nishant Shinde <[email protected]> nishant-s7
 
 Nithin Katta <[email protected]> KATTA NAGA NITHIN

CONTRIBUTORS

@@ -135,6 +135,7 @@ Yaswanth Kosuru <[email protected]>
 Yernar Yergaziyev <[email protected]>
 Yuvi Mittal <[email protected]>
 ekambains <[email protected]>
+fadiothman22 <[email protected]>
 olenkabilonizhka <[email protected]>
 pranav-1720 <[email protected]>
 rainn <[email protected]>