Skip to content

Commit 8dfe021

Browse files
committed
fix: clean-up nonfibonacci implementation and remove unused deps
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 9c157a5 commit 8dfe021

File tree

4 files changed

+8
-39
lines changed

4 files changed

+8
-39
lines changed

lib/node_modules/@stdlib/math/base/special/nonfibonacci/include/stdlib/math/base/special/nonfibonacci.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ extern "C"
3232
/**
3333
* Computes the nth non-Fibonacci number.
3434
*/
35-
double stdlib_base_nonfibonacci( const int32_t x );
35+
double stdlib_base_nonfibonacci( const int32_t n );
3636

3737
#ifdef __cplusplus
3838
}

lib/node_modules/@stdlib/math/base/special/nonfibonacci/manifest.json

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,8 @@
3636
"libraries": [],
3737
"libpath": [],
3838
"dependencies": [
39+
"@stdlib/math/base/napi/unary",
3940
"@stdlib/constants/float64/nan",
40-
"@stdlib/constants/float64/phi",
41-
"@stdlib/constants/float64/pinf",
42-
"@stdlib/math/base/assert/is-integer",
43-
"@stdlib/math/base/assert/is-nan",
4441
"@stdlib/math/base/special/floor",
4542
"@stdlib/math/base/special/ln"
4643
]
@@ -57,10 +54,6 @@
5754
"libpath": [],
5855
"dependencies": [
5956
"@stdlib/constants/float64/nan",
60-
"@stdlib/constants/float64/phi",
61-
"@stdlib/constants/float64/pinf",
62-
"@stdlib/math/base/assert/is-integer",
63-
"@stdlib/math/base/assert/is-nan",
6457
"@stdlib/math/base/special/floor",
6558
"@stdlib/math/base/special/ln"
6659
]
@@ -77,10 +70,6 @@
7770
"libpath": [],
7871
"dependencies": [
7972
"@stdlib/constants/float64/nan",
80-
"@stdlib/constants/float64/phi",
81-
"@stdlib/constants/float64/pinf",
82-
"@stdlib/math/base/assert/is-integer",
83-
"@stdlib/math/base/assert/is-nan",
8473
"@stdlib/math/base/special/floor",
8574
"@stdlib/math/base/special/ln"
8675
]

lib/node_modules/@stdlib/math/base/special/nonfibonacci/src/main.c

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -16,23 +16,19 @@
1616
* limitations under the License.
1717
*/
1818

19-
#include <stdint.h>
20-
19+
#include "stdlib/math/base/special/nonfibonacci.h"
2120
#include "stdlib/constants/float64/nan.h"
22-
#include "stdlib/constants/float64/phi.h"
23-
#include "stdlib/constants/float64/pinf.h"
24-
#include "stdlib/math/base/assert/is_integer.h"
25-
#include "stdlib/math/base/assert/is_nan.h"
2621
#include "stdlib/math/base/special/floor.h"
2722
#include "stdlib/math/base/special/ln.h"
23+
#include <stdint.h>
2824

29-
#define SQRT5 2.23606797749979
30-
#define LN_PHI 0.48121182506
25+
static const double SQRT5 = 2.23606797749979;
26+
static const double LN_PHI = 0.48121182506;
3127

3228
/**
3329
* Computes the nth non-Fibonacci number.
3430
*
35-
* @param x input value
31+
* @param n input value
3632
* @return output value
3733
*
3834
* @example
@@ -48,14 +44,6 @@
4844
* // returns 7.0
4945
*
5046
* @example
51-
* double y = stdlib_base_nonfibonacci( NaN );
52-
* // returns NaN
53-
*
54-
* @example
55-
* double y = stdlib_base_nonfibonacci( 3.14 );
56-
* // returns NaN
57-
*
58-
* @example
5947
* double y = stdlib_base_nonfibonacci( -1 );
6048
* // returns NaN
6149
*/
@@ -64,12 +52,7 @@ double stdlib_base_nonfibonacci( const int32_t n ) {
6452
double b;
6553
int32_t mut_n = n;
6654

67-
if (
68-
stdlib_base_is_nan( n ) ||
69-
!stdlib_base_is_integer( n ) ||
70-
n < 1.0 ||
71-
n == STDLIB_CONSTANT_FLOAT64_PINF
72-
) {
55+
if ( n < 1 ) {
7356
return STDLIB_CONSTANT_FLOAT64_NAN;
7457
}
7558

lib/node_modules/@stdlib/stats/base/dists/cosine/cdf/manifest.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
"dependencies": [
4141
"@stdlib/math/base/napi/ternary",
4242
"@stdlib/math/base/assert/is-nan",
43-
"@stdlib/constants/float64/eps",
4443
"@stdlib/math/base/special/sinpi",
4544
"@stdlib/constants/float64/pi"
4645
]
@@ -58,7 +57,6 @@
5857
"libpath": [],
5958
"dependencies": [
6059
"@stdlib/math/base/assert/is-nan",
61-
"@stdlib/constants/float64/eps",
6260
"@stdlib/math/base/special/sinpi",
6361
"@stdlib/constants/float64/pi"
6462
]
@@ -76,7 +74,6 @@
7674
"libpath": [],
7775
"dependencies": [
7876
"@stdlib/math/base/assert/is-nan",
79-
"@stdlib/constants/float64/eps",
8077
"@stdlib/math/base/special/sinpi",
8178
"@stdlib/constants/float64/pi"
8279
]

0 commit comments

Comments
 (0)