Skip to content

Commit d83817d

Browse files
committed
fix: remove cppcheck suppress, update benchmarks to use array/uniform
1 parent 17d1d56 commit d83817d

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/benchmark/benchmark.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var Float64Array = require( '@stdlib/array/float64' );
25-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2625
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2726
var pkg = require( './../package.json' ).name;
2827
var variance = require( './../lib' );
@@ -38,12 +37,8 @@ bench( pkg, function benchmark( b ) {
3837
var i;
3938

4039
len = 100;
41-
r = new Float64Array( len );
42-
p = new Float64Array( len );
43-
for ( i = 0; i < len; i++ ) {
44-
r[ i ] = ( randu() * 10.0 ) + 1.0; // Treat r as double
45-
p[ i ] = ( randu() * 0.8 ) + 0.1;
46-
}
40+
r = uniform( len, 1.0, 11.0 ); // Treat r as double
41+
p = uniform( len, 0.1, 0.9 );
4742

4843
b.tic();
4944
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/benchmark/benchmark.native.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var Float64Array = require( '@stdlib/array/float64' );
26-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2726
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2827
var tryRequire = require( '@stdlib/utils/try-require' );
2928
var pkg = require( './../package.json' ).name;
@@ -47,12 +46,8 @@ bench( pkg + '::native', opts, function benchmark( b ) {
4746
var i;
4847

4948
len = 100;
50-
r = new Float64Array( len );
51-
p = new Float64Array( len );
52-
for ( i = 0; i < len; i++ ) {
53-
r[ i ] = ( randu() * 10.0 ) + 1.0; // Treat r as double
54-
p[ i ] = ( randu() * 0.8 ) + 0.1;
55-
}
49+
r = uniform( len, 1.0, 11.0 ); // Treat r as double
50+
p = uniform( len, 0.1, 0.9 );
5651

5752
b.tic();
5853
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/src/addon.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,4 @@
1919
#include "stdlib/stats/base/dists/negative-binomial/variance.h"
2020
#include "stdlib/math/base/napi/binary.h"
2121

22-
// cppcheck-suppress shadowFunction
2322
STDLIB_MATH_BASE_NAPI_MODULE_DD_D( stdlib_base_dists_negative_binomial_variance )

0 commit comments

Comments
 (0)