Skip to content

Commit e2d6069

Browse files
authored
chore: apply suggestions from code review
Signed-off-by: Philipp Burckhardt <[email protected]>
1 parent b33e391 commit e2d6069

File tree

2 files changed

+7
-37
lines changed
  • lib/node_modules/@stdlib/stats/base/dists/logistic/quantile

2 files changed

+7
-37
lines changed

lib/node_modules/@stdlib/stats/base/dists/logistic/quantile/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,11 +221,11 @@ int main( void ) {
221221
double y;
222222
int i;
223223
for ( i = 0; i < 25; i++ ) {
224-
mu = random_uniform( 0.0, 1.0 );
225-
mu = random_uniform( 0.0, 10.0 ) - 5.0;
224+
p = random_uniform( 0.0, 1.0 );
225+
mu = random_uniform( -5.0, 5.0 );
226226
s = random_uniform( 0.0, 20.0 );
227227
y = stdlib_base_dists_logistic_quantile( p, mu, s );
228-
printf( "p:: %lf, µ:: %lf, s: %lf, quantile(X;p,µ,s): %lf\n", p, mu, s, y );
228+
printf( "p:: %lf, µ:: %lf, s: %lf, Q(p;µ,s): %lf\n", p, mu, s, y );
229229
}
230230
}
231231
```

lib/node_modules/@stdlib/stats/base/dists/logistic/quantile/src/main.c

Lines changed: 4 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -20,47 +20,17 @@
2020
#include "stdlib/math/base/assert/is_nan.h"
2121
#include "stdlib/math/base/special/ln.h"
2222

23-
2423
/**
2524
* Evaluates the quantile function for a logistic distribution with location parameter `mu` and scale parameter `s` at a probability `p`.
2625
*
27-
* @param {Probability} p - input value
28-
* @param {number} mu - location parameter
29-
* @param {NonNegativeNumber} s - scale parameter
30-
* @returns {number} evaluated quantile function
26+
* @param p input value
27+
* @param mu location parameter
28+
* @param s scale parameter
29+
* @return evaluated quantile function
3130
*
3231
* @example
3332
* double y = stdlib_base_dists_logistic_quantile( 0.8, 0.0, 1.0 );
3433
* // returns ~1.386
35-
*
36-
* @example
37-
* double y = stdlib_base_dists_logistic_quantile( 0.5, 4.0, 2.0 );
38-
* // returns 4.0
39-
*
40-
* @example
41-
* double y = stdlib_base_dists_logistic_quantile( 1.1, 0.0, 1.0 );
42-
* // returns NaN
43-
*
44-
* @example
45-
* double y = stdlib_base_dists_logistic_quantile( -0.2, 0.0, 1.0 );
46-
* // returns NaN
47-
*
48-
* @example
49-
* double y = stdlib_base_dists_logistic_quantile( NaN, 0.0, 1.0 );
50-
* // returns NaN
51-
*
52-
* @example
53-
* double y = stdlib_base_dists_logistic_quantile( 0.0, NaN, 1.0 );
54-
* // returns NaN
55-
*
56-
* @example
57-
* double y = stdlib_base_dists_logistic_quantile( 0.0, 0.0, NaN );
58-
* // returns NaN
59-
*
60-
* @example
61-
* // Negative scale parameter:
62-
* double y = stdlib_base_dists_logistic_quantile( 0.5, 0.0, -1.0 );
63-
* // returns NaN
6434
*/
6535
double stdlib_base_dists_logistic_quantile( const double p, const double mu, const double s ) {
6636
if (

0 commit comments

Comments
 (0)