Skip to content

Commit ec55d90

Browse files
committed
fix: correct header order, validation, style issues, and use uniform over randu
1 parent 23654c2 commit ec55d90

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

lib/node_modules/@stdlib/stats/base/dists/chi/pdf/benchmark/benchmark.native.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var Float64Array = require( '@stdlib/array/float64' );
26-
var randu = require( '@stdlib/random/base/randu' );
26+
var uniform = require( '@stdlib/random/base/uniform' );
2727
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2828
var tryRequire = require( '@stdlib/utils/try-require' );
2929
var pkg = require( './../package.json' ).name;
@@ -50,8 +50,8 @@ bench( pkg + '::native', opts, function benchmark( b ) {
5050
x = new Float64Array( len );
5151
k = new Float64Array( len );
5252
for ( i = 0; i < len; i++ ) {
53-
x[ i ] = ( randu() * 20.0 ) - 10.0;
54-
k[ i ] = ( randu() * 20.0 ) + 0.1;
53+
x[ i ] = uniform( -10.0, 10.0 );
54+
k[ i ] = uniform( 0.1, 20.1 );
5555
}
5656

5757
b.tic();

lib/node_modules/@stdlib/stats/base/dists/chi/pdf/examples/c/example.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,5 @@ int main( void ) {
3737
y = stdlib_base_dists_chi_pdf( x, k );
3838
printf( "x: %lf, k: %lf, f(x;k): %lf\n", x, k, y );
3939
}
40+
return 0;
4041
}

lib/node_modules/@stdlib/stats/base/dists/chi/pdf/src/addon.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,4 @@
1919
#include "stdlib/math/base/napi/binary.h"
2020
#include "stdlib/stats/base/dists/chi/pdf.h"
2121

22-
// cppcheck-suppress shadowFunction
2322
STDLIB_MATH_BASE_NAPI_MODULE_DD_D( stdlib_base_dists_chi_pdf )

lib/node_modules/@stdlib/stats/base/dists/chi/pdf/src/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
* limitations under the License.
1717
*/
1818

19+
#include "stdlib/stats/base/dists/chi/pdf.h"
1920
#include "stdlib/constants/float64/pinf.h"
2021
#include "stdlib/math/base/assert/is_nan.h"
2122
#include "stdlib/math/base/special/exp.h"
2223
#include "stdlib/math/base/special/gamma.h"
2324
#include "stdlib/math/base/special/pow.h"
24-
#include "stdlib/stats/base/dists/chi/pdf.h"
2525

2626
/**
2727
* Evaluates the probability density function (PDF) for a Chi distribution with degrees of freedom `k` at a value `x`.
@@ -37,7 +37,7 @@
3737
double stdlib_base_dists_chi_pdf( const double x, const double k ) {
3838
double out;
3939
double kh;
40-
if ( stdlib_base_is_nan( x ) || stdlib_base_is_nan( k ) || k <= 0.0 ) {
40+
if ( stdlib_base_is_nan( x ) || stdlib_base_is_nan( k ) || k < 0.0 ) {
4141
return 0.0 / 0.0; // NaN
4242
}
4343
if ( k == 0.0 ) {

0 commit comments

Comments
 (0)