-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add datasets/penguins
#1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you very much for you PR! I left a few minor requests and change suggestions. I didn't see any issues with respect to how the licenses are presented.
lib/node_modules/@stdlib/datasets/penguins/benchmark/benchmark.browser.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/datasets/penguins/benchmark/benchmark.browser.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/datasets/penguins/benchmark/benchmark.browser.js
Outdated
Show resolved
Hide resolved
If applied, this commit will bring in the changes to add the penguin dataset as an alternative to the iris dataset Closes: #300
@Planeshifter - thanks for the review! I have made all the suggested changes. As an add on, I had tried to create a scatter plot visualizing the different species with Flipper Length vs Body Mass in the Code:
Output of the above code: What I am hoping to achieve (minus the best fit line): |
@Infinage No need to add an |
Got you, so do I need to have this file removed? |
Did another review; I ended up updating the copyright year and making a few small adjustments. But would be great to finally get this nice dataset in! 🚀 |
@Planeshifter It looks to me like the README references are not formatted correctly. These should also be added to the bibliography database. |
Closes: #300
Description
This pull request:
Related Issues
This pull request:
Questions
Unsure about the licensing related information for this dataset, I had simply cloned these details from
pace-boston-house-prices
dataset with minor modifications. Might need some extra eyes reviewing theLICENSE
&README.md
's LICENSE section. Also wanted to know if needed to get in touch with the dataset authors for permissions?Other
Data was cloned from this repo URL and the column names were altered to follow camel Case conventions. No other changes were made to the data.
Checklist
@stdlib-js/reviewers