Skip to content

Conversation

Rishi3bhu1
Copy link

Resolves # 1649.

Description

What is the purpose of this pull request?

This pull request:

  • Add examples of the functions present in stats/base/dists/weibull namespace and their usage.
  • Adds example sets in README.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter Planeshifter changed the title issue 1649 docs: improve README examples of stats/base/dists/weibull namespace Mar 4, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Documentation Improvements, additions, or changes to documentation. labels Mar 4, 2024
@Planeshifter
Copy link
Member

@Rishi3bhu1 the example code has to be runnable, but your changes invoke functions that do not exist in the module scope. You will need to directly access them from the namespace object via dot-notation. Notice also that we include spaces around function parentheses.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 5, 2024
@Planeshifter Planeshifter added the autoclose: Stale Pull request which should be auto-closed as considered stale. label Oct 6, 2024
@stdlib-bot
Copy link
Contributor

This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one.

We appreciate your interest in contributing to stdlib!

@stdlib-bot stdlib-bot closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Stale Pull request which should be auto-closed as considered stale. Documentation Improvements, additions, or changes to documentation. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: improve README examples of stats/base/dists/weibull namespace

3 participants