feat!: improve type declarations for utils/map-arguments
#2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
changed the title
utils/map-arguments
Planeshifter
approved these changes
Oct 14, 2024
Planeshifter
changed the title
utils/map-argumentsutils/map-arguments
Planeshifter
added
the
Ready To Merge
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
aayush0325
pushed a commit
to aayush0325/stdlib
that referenced
this pull request
Nov 11, 2024
This change significantly improves the type definition of the mapArguments function, transitioning from broad 'Function' types to specific, generic types and implementing conditional this context based on thisArg presence. BREAKING CHANGE: function signature and return type now more strictly typed The mapArguments function now uses generic types instead of 'Function', and its return type depends on thisArg presence. Users should review and update their usage of mapArguments, particularly: - Ensure provided functions match the new, stricter type requirements - Update any type assertions or checks where mapArguments is used - Pay special attention to contexts where this binding is significant PR-URL: stdlib-js#2050 Closes: stdlib-js#1087 Co-authored-by: Philipp Burckhardt <[email protected]> Co-authored-by: Prajwal Kulkarni <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1087
Description
This pull request:
mapArgumentsfunction.Related Issues
This pull request:
@stdlib/utils/map-arguments#1087Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers