docs: improve README examples of lib/node_modules/@stdlib/constants/u… #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nicode I have read and understood the Code of Conduct. Searched for existing issues and pull requests. The issue name begins with RFC:. Signed-off-by: Muhammad Farjad <[email protected]>
stdlib-bot
reviewed
Mar 31, 2024
kgryte
reviewed
Apr 2, 2024
|
|
||
| > Unicode constants. | ||
| <section class="usage"> |
kgryte
reviewed
Apr 2, 2024
| console.log( 'Maximum BMP code point:', constants.MAX_BMP ); | ||
| ``` | ||
|
|
||
| #### constants |
There was a problem hiding this comment.
Why was this change made? Where else in the project do we make the API heading level 2?
kgryte
reviewed
Apr 2, 2024
Comment on lines
+29
to
+34
|
|
||
| // Maximum Unicode code point: | ||
| console.log( 'Maximum Unicode code point:', constants.MAX ); | ||
|
|
||
| // Maximum Basic Multilingual Plane (BMP) code point: | ||
| console.log( 'Maximum BMP code point:', constants.MAX_BMP ); |
There was a problem hiding this comment.
The first code block is always the import. Please see other packages in the project.
kgryte
requested changes
Apr 2, 2024
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1566 .
Description
Related Issues
This pull request:
constants/unicodenamespace #1566constants/unicodenamespace #1566Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers