Skip to content

Conversation

Ayansaxena24
Copy link

Updating test.ts by adding few additional tests for the issue --> Insufficient TypeScript declaration tests for @stdlib/utils/circular-buffer #474

Resolves #474

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves # 474
  • fixes # 474

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Updating test.ts by adding few additional tests for the issue --> Insufficient TypeScript declaration tests for @stdlib/utils/circular-buffer stdlib-js#474
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not follow the conventions used in other test.ts files in other packages. Please consult those packages and revise the PR accordingly.

@kgryte
Copy link
Member

kgryte commented Apr 2, 2024

Additionally, in order for this PR to be reviewed, please check the box in the OP indicating that you've read the contributing guidelines. This needs to be checked in order to confirm that you agree to licensing terms and the Developer's Certificate of Origin.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Apr 2, 2024
@Planeshifter
Copy link
Member

Closing this PR due to inactivity and unaddressed feedback. If you would like to revive it, merge conflicts will have to be addressed first. Thank you either way for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficient TypeScript declaration tests for @stdlib/utils/circular-buffer

4 participants