feat: add array/base/cunone-by
#2615
Conversation
|
@kgryte can you please review this !!!!! |
kgryte
changed the title
array/base/cunone-by
kgryte
added
Needs Review
There was a problem hiding this comment.
This README needs to be updated, as it does not match the style and conventions of other similar files in this project. Please update.
There was a problem hiding this comment.
I am working on it, actually having some examinations up my sleeve.So preparing for them.
There was a problem hiding this comment.
The indentation of this file is off.
| } | ||
| } | ||
|
|
||
| main(); No newline at end of file |
There was a problem hiding this comment.
You need to add trailing newlines. Please ensure EditorConfig is installed as discussed in the contributing guidelines.
| if ( !isArray( y ) || y !== out ) { | ||
| b.fail( 'should return the output array' ); | ||
| } | ||
| for ( i = 0; i < y.length; i++ ) { |
There was a problem hiding this comment.
This check is unnecessary. Remove.
| @@ -0,0 +1,52 @@ | |||
| {{alias}}( x, predicate ) | |||
There was a problem hiding this comment.
Match the conventions used elsewhere in this project.
| "type": "opencollective", | ||
| "url": "https://opencollective.com/stdlib" | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Trailing newlines here and everywhere.
| }); | ||
|
|
||
| tape( 'the function handles arrays with all elements failing the test', function test( t ) { | ||
| var x = [ -1, -2, -3, -4, -5 ]; |
There was a problem hiding this comment.
The order of declarations violates our lint rules. Make sure you have run make init to ensure automation runs on commit and push.
| } | ||
| }); | ||
|
|
||
| // Add more tests as needed No newline at end of file |
|
|
||
| tape( 'the function returns an array', function test( t ) { | ||
| var out = cunoneBy( [1, 2, 3], function() { return true; } ); | ||
| t.strictEqual( Array.isArray(out), true, 'returns an array' ); |
There was a problem hiding this comment.
We don't use the builtin isArray. Use our utility package.
|
Additionally all build failures need to be addressed before this PR can be merged or considered for further review. |
kgryte
added
Needs Changes
|
Closing as another PR with this package has meanwhile been merged. Thanks for your efforts and interest in |
4 participants
Resolves #2325 .
Description
This pull request:
Related Issues
This pull request:
@stdlib/array/base/cunone-by#2325Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers