Skip to content

feat: add array/base/cuany-by-right #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 25, 2024
Merged

feat: add array/base/cuany-by-right #2667

merged 11 commits into from
Sep 25, 2024

Conversation

DevMhrn
Copy link
Contributor

@DevMhrn DevMhrn commented Jul 26, 2024

Resolves #2327

Description

This pull request introduces the @stdlib/array/base/cuany-by-right package, which provides functions for iterating over an array from right-to-left to determine if any element satisfies a given predicate function. The package includes the following functions:

  • cuanyByRight: Iterates over an array from right-to-left, returning a new array that indicates if any element satisfies the given predicate function.
  • cuanyByRight.assign: Similar to cuanyByRight, but allows setting output values in a provided output array with support for offset and stride.

Purpose

The main goal of this pull request is to add the @stdlib/array/base/cuany-by-right package to the codebase.

Related Issues

Questions for Reviewers

None.

Additional Information

None.

Checklist

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

kgryte
kgryte reviewed Jul 26, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 26, 2024
View reviewed changes
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Jul 26, 2024
@kgryte kgryte changed the title feat : added @stdlib/array/base/cuany-by-right (Cuany by right) feat : add array/base/cuany-by-right Jul 26, 2024
@kgryte
Copy link
Member

kgryte commented Jul 26, 2024

@DevMhrn Additionally, before this PR can be reviewed again and merged, all CI failures will need to be addressed.

@kgryte
Copy link
Member

kgryte commented Jul 26, 2024

/stdlib lint-autofix

@DevMhrn
Copy link
Contributor Author

DevMhrn commented Jul 27, 2024

@kgryte , I have updated some lines of code , by correcting some things , could you please review it

@DevMhrn
Copy link
Contributor Author

DevMhrn commented Jul 28, 2024

@kgryte please review it and let know the possible error or corrections, to contibute in this repo .

kgryte
kgryte reviewed Jul 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 28, 2024
View reviewed changes
kgryte
kgryte requested changes Jul 28, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still in need of significant clean-up. Before any further review can happen, all lint errors need to be resolved. Please consult existing packages in array/base and emulate the style and conventions as closely as you can and as appropriate.

@Planeshifter Planeshifter self-requested a review September 24, 2024 16:30
@Planeshifter Planeshifter changed the title feat : add array/base/cuany-by-right feat: add array/base/cuany-by-right Sep 25, 2024
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Sep 25, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `array/base/cuany-by-right`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2667
Closes: https://github.com/stdlib-js/stdlib/issues/2327

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Ready To Merge A pull request which is ready to be merged. labels Sep 25, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `array/base/cuany-by-right`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2667
Closes: https://github.com/stdlib-js/stdlib/issues/2327

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 5742947 into stdlib-js:develop Sep 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/cuany-by-right

4 participants

@DevMhrn @kgryte @stdlib-bot @Planeshifter