feat: add `array/base/cusome` #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Planeshifter merged 8 commits into stdlib-js:develop from yaswanthkosuru:feat/add-stdlib-array-base-cusome

Sep 23, 2024

Contributor

yaswanthkosuru commented Aug 14, 2024

Resolves #2322.

Description

add @stdlib/array/base/cusome

This pull request:

resolves [RFC]: add @stdlib/array/base/cusome.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

yaswanthkosuru added 2 commits

August 14, 2024 10:48


          feat: add @stdlib/array/base/cusome

85c1462


          fixup! feat: add @stdlib/array/base/cusome

749fbc6

kgryte added Feature Needs Review Utilities labels

kgryte changed the title ~~Feat/add stdlib array base cusome~~ feat: add array/base/cusome

Planeshifter reviewed

View reviewed changes

Member

Planeshifter left a comment

Thank you very much for your contribution.

Left a bunch of small suggestions that will ensure the PR aligns with our code style and documentation conventions, but otherwise this look good!

lib/node_modules/@stdlib/array/base/cusome/lib/main.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/package.json Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/lib/index.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/README.md Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/README.md Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

yaswanthkosuru added 2 commits

August 15, 2024 09:00


          fixup! fixup! feat: add @stdlib/array/base/cusome

f5cb5d4


          fixup! fixup! fixup! feat: add @stdlib/array/base/cusome

44a812d

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/benchmark/benchmark.assign.length.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/benchmark/benchmark.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/benchmark/benchmark.length.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/repl.txt Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/test.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/test.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/test.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/docs/types/test.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/examples/index.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/base/cusome/lib/assign.js Outdated Show resolved Hide resolved

kgryte requested changes

View reviewed changes

Member

kgryte left a comment

This PR needs a careful review and various clean-up. I've only done a partial review, but more attention to detail especially wrt existing project conventions will go a long way to helping moving this PR along.

kgryte added Needs Changes Do Not Merge and removed Needs Review labels

yaswanthkosuru added 3 commits

August 15, 2024 18:21


          fixup! fixup! fixup! fixup! feat: add @stdlib/array/base/cusome

c2fae07


          fixup! fixup! fixup! fixup! fixup! feat: add @stdlib/array/base/cusome

fd94674


          fixup! fixup! fixup! fixup! fixup! fixup! feat: add @stdlib/array/bas…

edd6ffb

…e/cusome

Contributor Author

yaswanthkosuru commented Aug 15, 2024

Hey @kgryte , @Planeshifter
I've made the requested changes as well as some additional improvements wrt existing project . Please review them and let me know if there's anything I've missed .

yaswanthkosuru requested review from Planeshifter and kgryte

August 16, 2024 03:58


          chore: minor changes

3c9ef7d

Planeshifter removed the Do Not Merge label

Member

Planeshifter commented Sep 23, 2024

Thanks @yaswanthkosuru! Did another review and will merge your PR shortly. We appreciate your contributions!

Planeshifter approved these changes

View reviewed changes

Planeshifter merged commit 2091d38 into stdlib-js:develop

10 of 11 checks passed

kgryte removed the Needs Changes label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Utilities