-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add array/base/cuevery-by-right
#2802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! 🚀
Notice that we use imperative statements, such as "Cumulatively test," in descriptions specifically for the package.json, index.js file, and the README introduction. In all other contexts, our convention is to use declarative statements, such as "Cumulatively tests."
The main change that would be great to make is to add support for Boolean and complex arrays in the assign
function.
lib/node_modules/@stdlib/array/base/cuevery-by-right/package.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by-right/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by-right/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by-right/lib/assign.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by-right/lib/assign.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by-right/lib/assign.js
Outdated
Show resolved
Hide resolved
Thanks for your comments! I'll make the changes
…On Sat, Sep 7, 2024, 7:58 AM Philipp Burckhardt ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ***@***.***/array/base/cuevery-by-right/lib/assign.js
<#2802 (comment)>:
> +* // returns [ true, null, true, null, false, null, false, null ]
+*
+* var bool = ( y === out );
+* // returns true
+*/
+function assign( x, out, stride, offset, predicate, thisArg ) {
+ var xo;
+ var oo;
+
+ xo = arraylike2object( x );
+ oo = arraylike2object( out );
+ if (
+ xo.accessorProtocol ||
+ oo.accessorProtocol
+ ) {
+ accessors( xo, oo, stride, offset, predicate, thisArg );
It would be great to add support for Boolean and complex arrays here.
See e.g.
https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/array/base/cuany/lib/assign.js
for reference.
—
Reply to this email directly, view it on GitHub
<#2802 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXDIVWVRIG3WUL6MA2RY2GLZVJQFTAVCNFSM6AAAAABMVKHNISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOBXGMYTONBVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Philipp Burckhardt <[email protected]>
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #2328
Description
This pull request:
@stdlib/array/base/cuevery-by-right
Related Issues
This pull request:
@stdlib/array/base/cuevery-by-right
#2328Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers