Skip to content

Conversation

GittyHarsha
Copy link
Contributor

Resolves #2328

Description

What is the purpose of this pull request?

This pull request:

  • Adds implementation to @stdlib/array/base/cuevery-by-right

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@GittyHarsha GittyHarsha marked this pull request as ready for review August 17, 2024 11:24
@Planeshifter Planeshifter self-requested a review September 2, 2024 21:09
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 2, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! 🚀

Notice that we use imperative statements, such as "Cumulatively test," in descriptions specifically for the package.json, index.js file, and the README introduction. In all other contexts, our convention is to use declarative statements, such as "Cumulatively tests."

The main change that would be great to make is to add support for Boolean and complex arrays in the assign function.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Sep 7, 2024
@GittyHarsha
Copy link
Contributor Author

GittyHarsha commented Sep 7, 2024 via email

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Sep 19, 2024
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Sep 29, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `array/base/cuevery-by-right`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2802
Closes: https://github.com/stdlib-js/stdlib/issues/2328

Co-authored-by: GittyHarsha <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 5a50038 into stdlib-js:develop Sep 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Utilities Issue or pull request concerning general utilities.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/cuevery-by-right

4 participants