Skip to content

Conversation

Kaif987
Copy link
Contributor

@Kaif987 Kaif987 commented Aug 26, 2024

Resolves #2325

Description

What is the purpose of this pull request?

This pull request:

  • This pull request adds the @stdlib/array/base/cunone-by package that cumulatively tests whether no array element in a provided array passes a test implemented by a predicate function

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

This commit contains all inital changes for adding the `base/cunone-by` package.

Ref: stdlib-js#2325
Co-authored-by: Mohammad Kaif <[email protected]>
This commit aims to add the `base/cunone-by` package.

Ref: stdlib-js#2325
Co-authored-by: Mohammad Kaif <[email protected]>
@Kaif987 Kaif987 changed the title add(base): @stdlib/array/base/cunone-by package add: @stdlib/array/base/cunone-by package Aug 27, 2024
@Kaif987 Kaif987 changed the title add: @stdlib/array/base/cunone-by package feat: add @stdlib/array/base/cunone-by package Sep 1, 2024
@Planeshifter Planeshifter self-requested a review September 7, 2024 00:08
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 7, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Left a few comments concerning some doc fixes, but overall this looks very good!

@Kaif987
Copy link
Contributor Author

Kaif987 commented Sep 7, 2024

Hey @Planeshifter I have made the necessary changes. Is there anything else that I need to add

Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter changed the title feat: add @stdlib/array/base/cunone-by package feat: add array/base/cunone-by package Sep 8, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this! Thanks again for the PR!

@Planeshifter Planeshifter merged commit 24e9908 into stdlib-js:develop Sep 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/cunone-by

3 participants