Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #2888.

Description

What is the purpose of this pull request?

This pull request:

  • Adds the feature '@stdlib/assert/is-same-accessor-array'

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

  • Are the keywords in package.json correct?
  • Do I need to cover any more examples or tests other than Complex128Array and Complex64Array? I couldn't find any other ways to make Accessor Arrays

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • I am a first time contributor kindly forgive any rookie errors. I've tried my best to adhere to the Code Structure of this repository. Open to reviews!!

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@aayush0325
Copy link
Member Author

Ready for initial review @Planeshifter !

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@Planeshifter Planeshifter merged commit 7bb8e20 into stdlib-js:develop Sep 15, 2024
10 checks passed
@aayush0325 aayush0325 deleted the patch-2 branch September 16, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/assert/is-same-accessor-array

4 participants