Skip to content

Conversation

yaswanthkosuru
Copy link
Contributor

Resolves #2886.

Description

Add additonal package @stdlib/assert/is-same-array-like-object to check same array like objects.

This pull request:

Other

This Package is just same as is-same-array-like but it checks if objects also match or not .
ex:"bee",["b","e","e"] doesnt match.
i only find above one difference and wrote code according to these.

Checklist

  • Read, understood, and followed the contributing guidelines.
  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.

@stdlib-js/reviewers

@yaswanthkosuru
Copy link
Contributor Author

@Planeshifter Ready for initial Review

@Planeshifter Planeshifter self-requested a review September 15, 2024 20:19
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Looks great; made only a small change and will merge shortly.

Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit 15e6c71 into stdlib-js:develop Sep 15, 2024
10 checks passed
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add assert/is-same-array-like-object

3 participants