Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #1534

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Open to reviews!!

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 28, 2024
@aayush0325
Copy link
Member Author

@Planeshifter Ready for review!

@Planeshifter Planeshifter self-requested a review September 29, 2024 00:28
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 29, 2024
@aayush0325
Copy link
Member Author

Tried taking care of indentation here.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and updating the indentation!

Notice that in manifest.json, the dependencies array was missing @stdlib/math/base/assert/is-positive-zerof, which is used in ssort2hp.c.

You can use make examples-c-files, as e.g. in the below (file path may be different), to run the C examples:

make examples-c-files FILES='~/stdlib/lib/node_modules/@stdlib/blas/ext/base/ssort2hp/examples/c/example.c'   

Also, I noticed there are actually no C benchmarks in this package, so I removed that configuration from the manifest.json file.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Sep 29, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: update  `blas/ext/base/ssort2hp` to follow current project conventions

PR-URL: https://github.com/stdlib-js/stdlib/pull/2960
Closes: https://github.com/stdlib-js/stdlib/issues/1534

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@aayush0325
Copy link
Member Author

Okay, Noted. Will try to get more familiar with the code base next time onwards, thanks for your inputs they're great for my learning.

@Planeshifter Planeshifter merged commit c1552d8 into stdlib-js:develop Sep 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssort2hp to follow current project conventions

3 participants