-
-
Notifications
You must be signed in to change notification settings - Fork 907
refactor: update blas/ext/base/ssort2hp
to follow current project conventions
#2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Planeshifter Ready for review! |
Tried taking care of indentation here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and updating the indentation!
Notice that in manifest.json
, the dependencies
array was missing @stdlib/math/base/assert/is-positive-zerof
, which is used in ssort2hp.c
.
You can use make examples-c-files
, as e.g. in the below (file path may be different), to run the C examples:
make examples-c-files FILES='~/stdlib/lib/node_modules/@stdlib/blas/ext/base/ssort2hp/examples/c/example.c'
Also, I noticed there are actually no C benchmarks in this package, so I removed that configuration from the manifest.json
file.
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Okay, Noted. Will try to get more familiar with the code base next time onwards, thanks for your inputs they're great for my learning. |
Resolves #1534
Description
This pull request:
blas/ext/base/ssort2hp
to follow current project conventionsblas/ext/base/ssort2hp
to follow current project conventions #1534Related Issues
This pull request:
blas/ext/base/ssort2hp
to follow current project conventions #1534Questions
No.
Other
Open to reviews!!
Checklist
@stdlib-js/reviewers