Skip to content

Conversation

gururaj1512
Copy link
Member

Resolves #2543.

Description

What is the purpose of this pull request?
This pull request completes code coverage in blas/base/dznrm2 and blas/base/scnrm2

This pull request:

  • Adds testcases to blas/base/dznrm2 and blas/base/scnrm2 which covers 100% code

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@gururaj1512 gururaj1512 changed the title Test cases test: completes code coverage in blas/base/dznrm2 and blas/base/scnrm2 Oct 1, 2024
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 1, 2024
@kgryte kgryte added Needs Review A pull request which needs code review. Tests Pull requests specifically adding tests. labels Oct 1, 2024
@Planeshifter Planeshifter self-requested a review October 12, 2024 17:36
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Oct 12, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

test: completes code coverage in `blas/base/dznrm2` and `blas/base/scnrm2`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2977
Closes: https://github.com/stdlib-js/stdlib/issues/2543

Co-authored-by: Gururaj Gurram <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit c0a5dbe into stdlib-js:develop Oct 12, 2024
30 checks passed
@gururaj1512 gururaj1512 deleted the test-cases branch October 12, 2024 18:44
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
…base/scnrm2`

PR-URL: stdlib-js#2977
Closes: stdlib-js#2543

Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete code coverage in blas/base/dznrm2 and blas/base/scnrm2

4 participants