Skip to content

Conversation

headlessNode
Copy link
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor/cleanup blas/ext/base/dnannsumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 5, 2024
@headlessNode
Copy link
Member Author

headlessNode commented Oct 5, 2024

The failing test is from dnannsum which uses dnannsumkbn to compute the sum. It will be resolved once dnannsum is refactored.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Oct 5, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Oct 5, 2024
@headlessNode
Copy link
Member Author

headlessNode commented Oct 6, 2024

@kgryte Using CBLAS_INT is causing the format specifier error. I think we will need to define format specifiers for CBLAS_INT.

EDIT: Just saw that it is defined. Sorry for the oversight.

@kgryte
Copy link
Member

kgryte commented Nov 17, 2024

@headlessNode Based on feedback in the other PRs, does this PR need some further tweaks?

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 18, 2024

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dnannsumkbn $\color{green}491/491$
$\color{green}+100.00\%$
$\color{green}42/42$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}491/491$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode
Copy link
Member Author

@kgryte ready for review.

@kgryte
Copy link
Member

kgryte commented Nov 19, 2024

@headlessNode This PR has a failing test atm.

@headlessNode
Copy link
Member Author

@kgryte the failing test is expected.

@kgryte
Copy link
Member

kgryte commented Nov 19, 2024

Ah, right. It is a downstream test suite which is failing.

@headlessNode headlessNode requested a review from kgryte November 19, 2024 22:13
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 20, 2024
@kgryte
Copy link
Member

kgryte commented Nov 20, 2024

As mentioned in #2988 (comment), the CI test failure in the downstream library is expected. This failure will be resolved in a subsequent PR/commit. As such, I will go ahead and merge.

@kgryte kgryte merged commit f9fa434 into stdlib-js:develop Nov 20, 2024
11 of 12 checks passed
@headlessNode headlessNode deleted the dnannsumkbn-refactor branch November 20, 2024 15:48
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants