-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add C ndarray
API and refactor blas/ext/base/dnannsumkbn
#2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The failing test is from |
lib/node_modules/@stdlib/blas/ext/base/dnannsumkbn/benchmark/c/benchmark.length.c
Outdated
Show resolved
Hide resolved
@kgryte Using EDIT: Just saw that it is defined. Sorry for the oversight. |
@headlessNode Based on feedback in the other PRs, does this PR need some further tweaks? |
Coverage Report
The above coverage report was generated for the changes in this PR. |
@kgryte ready for review. |
@headlessNode This PR has a failing test atm. |
@kgryte the failing test is expected. |
Ah, right. It is a downstream test suite which is failing. |
lib/node_modules/@stdlib/blas/ext/base/dnannsumkbn/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Muhammad Haris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @headlessNode!
As mentioned in #2988 (comment), the CI test failure in the downstream library is expected. This failure will be resolved in a subsequent PR/commit. As such, I will go ahead and merge. |
PR-URL: stdlib-js#2988 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>
Resolves none.
Description
This pull request:
ndarray
API and refactor/cleanupblas/ext/base/dnannsumkbn
Related Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers