Skip to content

feat: add C ndarray API and refactor blas/ext/base/dnansumkbn #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 30, 2024
Merged

feat: add C ndarray API and refactor blas/ext/base/dnansumkbn #2996

merged 10 commits into from
Oct 30, 2024

Conversation

headlessNode
Copy link
Member

@headlessNode headlessNode commented Oct 9, 2024 •
edited
Loading

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor/cleanup blas/ext/base/dnansumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 9, 2024
headlessNode
headlessNode commented Oct 11, 2024
View reviewed changes
headlessNode
headlessNode commented Oct 11, 2024
View reviewed changes
@kgryte
Copy link
Member

kgryte commented Oct 19, 2024

@headlessNode The downstream test failure is expected in this PR?

@headlessNode
Copy link
Member Author

@kgryte Yes, the dnansum uses dnansumkbn for computing the sum. Should be fixed when dnansum is refactored.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. C Issue involves or relates to C. labels Oct 19, 2024
kgryte
kgryte reviewed Oct 29, 2024
View reviewed changes
kgryte
kgryte reviewed Oct 29, 2024
View reviewed changes
kgryte
kgryte reviewed Oct 30, 2024
View reviewed changes
kgryte
kgryte approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@Planeshifter
Copy link
Member

Will merge shortly.

Failing CI checks are due to a) cppcheck errors and b) dnansum unit test being in need of updating due to the equivalent PR of this one for dnansumors, which also changed the behavior for a stride of zero.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Oct 30, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C `ndarray` API and refactor `blas/ext/base/dnansumkbn`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2996

Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 371a494 into stdlib-js:develop Oct 30, 2024
16 of 18 checks passed
@headlessNode headlessNode deleted the dnansumkbn-refactor branch October 30, 2024 01:57
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Nov 9, 2024
@headlessNode @kgryte @Neerajpathak07
feat: add C ndarray API and refactor blas/ext/base/dnansumkbn
37345bc 
PR-URL: stdlib-js#2996

Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@headlessNode @kgryte @aayush0325
feat: add C ndarray API and refactor blas/ext/base/dnansumkbn
f2b5948 
PR-URL: stdlib-js#2996

Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@headlessNode @kgryte @Planeshifter @stdlib-bot