feat: add math/base/special/wrapf
#3055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gunjjoshi, could you review this PR? Some checks are failing, need guidance for it. |
gunjjoshi
reviewed
Nov 3, 2024
1 task
Planeshifter
added a commit
that referenced
this pull request
Nov 10, 2024
PR-URL: #3059 Ref: #2997 Ref: #3055 Ref: #649 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Gunj Joshi <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
aayush0325
pushed a commit
to aayush0325/stdlib
that referenced
this pull request
Nov 11, 2024
PR-URL: stdlib-js#3059 Ref: stdlib-js#2997 Ref: stdlib-js#3055 Ref: stdlib-js#649 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Gunj Joshi <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
|
/stdlib merge |
kgryte
added
Feature
gunjjoshi
requested changes
Nov 19, 2024
lib/node_modules/@stdlib/math/base/special/wrapf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/wrapf/test/test.native.js
Outdated
Show resolved
Hide resolved
|
@gururaj1512 Can you go through the CI failures and make necessary changes in this PR? There are some linting errors and test failures. |
1 task
gunjjoshi
added
Needs Changes
|
/stdlib merge |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
1 task
1 task
|
/stdlib merge |
stdlib-bot
added
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
anandkaranubc
previously approved these changes
Jun 1, 2025
kgryte
removed
the
Needs Changes
kgryte
reviewed
Jun 2, 2025
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 2, 2025
lib/node_modules/@stdlib/math/base/special/wrapf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Jun 2, 2025
lib/node_modules/@stdlib/math/base/special/wrapf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 2, 2025
lib/node_modules/@stdlib/math/base/special/wrapf/include/stdlib/math/base/special/wrapf.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 2, 2025
Signed-off-by: Athan <[email protected]>
anandkaranubc
added a commit
to anandkaranubc/stdlib
that referenced
this pull request
Jun 3, 2025
PR-URL: stdlib-js#3055 Ref: stdlib-js#649 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Karan Anand <[email protected]> Reviewed-by: Gunj Joshi <[email protected]> Co-authored-by: stdlib-bot <[email protected]> Co-authored-by: Karan Anand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a part of #649
Description
math/base/special/wrapf, which would be the single-precision equivalent for math/base/special/wrap.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers