Skip to content

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor blas/ext/base/dsapxsumpw

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 9, 2024
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode headlessNode marked this pull request as ready for review November 9, 2024 10:25
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte kgryte added C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Nov 18, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 18, 2024

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsapxsumpw $\color{green}468/468$
$\color{green}+100.00\%$
$\color{green}36/36$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}468/468$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode
Copy link
Member Author

The check copyright years CI script is considering main.c a new file, hence the failure.

@headlessNode
Copy link
Member Author

@kgryte was the cppcheck update necessary?

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

According to @Planeshifter, yes, as GitHub actions updated and cppcheck could no longer compile. We thus migrated to the latest version, but the linting rules have updated and we're playing catch-up. 😬

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

@headlessNode I am not sure how we'd satisfy the current lint warning. Ideas?

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

If there isn't an easy workaround/fix, we could also suppress the lint rule for the offending line(s).

@headlessNode
Copy link
Member Author

@kgryte not sure. Using malloc would be unnecessary. I think suppressing the rule seems reasonable in this case.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

@headlessNode Seems fine with me. At some point, we do need to refactor benchmarks to use malloc, but that can be saved for another day.

@headlessNode
Copy link
Member Author

@kgryte That could be a nice set of good first issues.

@headlessNode headlessNode requested a review from kgryte November 18, 2024 09:20
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 18, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 18, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @headlessNode. Left an initial round of comments.

@headlessNode
Copy link
Member Author

@kgryte changes applied. The test failure from a downstream test suite.

@headlessNode headlessNode requested a review from kgryte November 19, 2024 11:39
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 19, 2024
@kgryte
Copy link
Member

kgryte commented Nov 19, 2024

As mentioned in #3083 (comment), the test failure in the downstream library is expected and will be resolved in a subsequent PR/commit. As such, I'll go ahead and merge.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Nov 19, 2024
@kgryte kgryte merged commit b4c3fc8 into stdlib-js:develop Nov 19, 2024
18 of 19 checks passed
@headlessNode headlessNode deleted the dsapxsumpw-refactor branch November 21, 2024 13:08
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
PR-URL: stdlib-js#3083
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Muhammad Haris <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants