-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add C ndarray
API and refactor blas/ext/base/dsapxsumpw
#3083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Muhammad Haris <[email protected]>
lib/node_modules/@stdlib/blas/ext/base/dsapxsumpw/lib/dsapxsumpw.js
Outdated
Show resolved
Hide resolved
/stdlib merge |
Coverage Report
The above coverage report was generated for the changes in this PR. |
The |
Signed-off-by: Athan <[email protected]>
@kgryte was the |
According to @Planeshifter, yes, as GitHub actions updated and cppcheck could no longer compile. We thus migrated to the latest version, but the linting rules have updated and we're playing catch-up. 😬 |
@headlessNode I am not sure how we'd satisfy the current lint warning. Ideas? |
If there isn't an easy workaround/fix, we could also suppress the lint rule for the offending line(s). |
@kgryte not sure. Using |
@headlessNode Seems fine with me. At some point, we do need to refactor benchmarks to use |
@kgryte That could be a nice set of |
lib/node_modules/@stdlib/blas/ext/base/dsapxsumpw/docs/repl.txt
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsapxsumpw/docs/repl.txt
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsapxsumpw/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsapxsumpw/include/stdlib/blas/ext/base/dsapxsumpw.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsapxsumpw/lib/ndarray.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @headlessNode. Left an initial round of comments.
@kgryte changes applied. The test failure from a downstream test suite. |
lib/node_modules/@stdlib/blas/ext/base/dsapxsumpw/include/stdlib/blas/ext/base/dsapxsumpw.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dsapxsumpw/include/stdlib/blas/ext/base/dsapxsumpw.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @headlessNode!
As mentioned in #3083 (comment), the test failure in the downstream library is expected and will be resolved in a subsequent PR/commit. As such, I'll go ahead and merge. |
PR-URL: stdlib-js#3083 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Muhammad Haris <[email protected]> Signed-off-by: Athan Reines <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
Description
This pull request:
ndarray
API and refactorblas/ext/base/dsapxsumpw
Related Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers