Skip to content

Conversation

MVARUNREDDY8203
Copy link

Resolves #3017

Description

What is the purpose of this pull request?

This pull request:

this pull request :

  • resolves the issue with splitting sentences where the previous version wrongly splits sentences on punctuation marks before closing " or '

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@MVARUNREDDY8203
Copy link
Author

MVARUNREDDY8203 commented Nov 10, 2024

this pr solves the issue #3017

I have added logic to ensure that punctuation marks like ! or ? followed by closing " or ' don't split the sentences there after.
I have run all tests and all tests have passed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MVARUNREDDY8203 Can you explain why this PR is changing this file?

@kgryte kgryte added the Do Not Merge Pull request which should not be merged. label Nov 13, 2024
@kgryte kgryte changed the title fix: resolve issue #3017 with sentence splitting fix: update logic for splitting sentences Nov 13, 2024
@kgryte kgryte added the Needs Discussion Needs further discussion. label Nov 13, 2024
@Planeshifter Planeshifter added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Jun 23, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Do Not Merge Pull request which should not be merged. Needs Discussion Needs further discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: nlp-sentencize wrongly breaks sentences in quotation marks

4 participants