Skip to content

Conversation

AbhijitRaut04
Copy link
Contributor

Resolves #3180 .

Description

What is the purpose of this pull request?

This pull request:

  • implements the mskbinary4d package for masked binary operations in the array/base namespace.
  • and provides a 4D equivalent of the mskbinary4d package for binary callbacks using a mask array.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Nov 20, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 21, 2024

Coverage Report

Package Statements Branches Functions Lines
array/base/mskbinary5d $\color{green}186/186$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}186/186$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@AbhijitRaut04
Copy link
Contributor Author

@Planeshifter Please review this PR.

@AbhijitRaut04
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 22, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 22, 2024
@kgryte kgryte changed the title feat: add implementation for array/base/mskbinary5d feat: add array/base/mskbinary5d Nov 25, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @AbhijitRaut04!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 25, 2024
@kgryte kgryte merged commit 34ae5c9 into stdlib-js:develop Nov 25, 2024
13 checks passed
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/mskbinary5d

4 participants