Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #3378

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/arcsine/entropy

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 8, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 8, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/arcsine/entropy $\color{green}193/193$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}193/193$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

good evening, please give this a review @Planeshifter!

@aayush0325 aayush0325 changed the title feat: add C implementation for @stdlib/stats/base/dists/arcsine/entropy feat: add C implementation for stats/base/dists/arcsine/entropy Dec 12, 2024
@Planeshifter Planeshifter self-requested a review December 14, 2024 03:32
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get this in shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 14, 2024
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. and removed Needs Review A pull request which needs code review. labels Dec 14, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/arcsine/entropy`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3379
Closes: https://github.com/stdlib-js/stdlib/issues/3378

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: aayush0325 <aayush25khanna@gmail,com>
Co-authored-by: aayush0325 <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 222ef72 into stdlib-js:develop Dec 14, 2024
28 checks passed
@aayush0325 aayush0325 deleted the entropy branch February 16, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/entropy

3 participants