Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #3393

Description

What is the purpose of this pull request?

This pull request:

  • refactors math/base/special/cexp to follow latest project conventions to use functions developed by stdlib instead of the native C functions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 10, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 10, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cexp $\color{green}235/235$
$\color{green}+100.00\%$
$\color{green}16/16$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}235/235$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@aayush0325 aayush0325 changed the title refactor: update math/base/special/cexp to follow latest project conventions refactor: update math/base/special/cexp to follow latest project conventions Dec 10, 2024
@aayush0325
Copy link
Member Author

good afternoon, please give this a review @gunjjoshi!

@gunjjoshi
Copy link
Member

gunjjoshi commented Dec 14, 2024

@aayush0325 Can you replace the use of stdlib_base_sin and stdlib_base_cos with stdlib_base_sincos at math/base/special/sincos? That would match what we have in the existing JS implementation of cexp here: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/cexp/lib/main.js#L101

@aayush0325
Copy link
Member Author

i've pushed the requested changes @gunjjoshi

@aayush0325 aayush0325 requested a review from gunjjoshi December 14, 2024 12:55
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 14, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 14, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: update `math/base/special/cexp` to follow latest project conventions

PR-URL: https://github.com/stdlib-js/stdlib/pull/3394
Closes: https://github.com/stdlib-js/stdlib/issues/3393

Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: aayush0325 <aayush25khanna@gmail,com>
Co-authored-by: aayush0325 <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 6e69af4 into stdlib-js:develop Dec 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: refactor math/base/special/cexp to follow latest project conventions

4 participants