Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #3446

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/betaprime/stdev along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@aayush0325
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/betaprime/stdev $\color{green}206/206$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}206/206$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @aayush0325. Spot checking your other PRs, it looks like you need to make similar changes across all of them. Please see #3354 for an idea of what we are looking for.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 12, 2024
@aayush0325 aayush0325 changed the title feat: add C implementation for @stdlib/stats/base/dists/betaprime/stdev feat: add C implementation for stats/base/dists/betaprime/stdev Dec 12, 2024
@aayush0325
Copy link
Member Author

aayush0325 commented Dec 12, 2024

good evening @kgryte, ive pushed the requested changes in this and all other PRs. thanks for your time!

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aayush0325! Let's get this one in.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 13, 2024
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Dec 13, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 13, 2024

PR Commit Message

feat: add C implementation for `stats/base/dists/betaprime/stdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3461
Closes: https://github.com/stdlib-js/stdlib/issues/3446

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit d1a200b into stdlib-js:develop Dec 13, 2024
20 checks passed
@aayush0325 aayush0325 deleted the betaprime-stdev branch February 16, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/betaprime/stdev

4 participants