Skip to content

Conversation

0PrashantYadav0
Copy link
Member

@0PrashantYadav0 0PrashantYadav0 commented Dec 12, 2024

Resolves #3469

Description

What is the purpose of this pull request?

This pull request:

  • Adds C implementation for binomial Mean
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the binomial Mean in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@0PrashantYadav0 0PrashantYadav0 changed the title feat: add C implementation for binomial Mean #3469 feat: add C implementation for binomial Mean Dec 12, 2024
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 12, 2024
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 12, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/binomial/mean $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@0PrashantYadav0
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. Statistics Issue or pull request related to statistical functionality. and removed bot: In Progress Pull request is currently awaiting automation. labels Dec 15, 2024
@0PrashantYadav0 0PrashantYadav0 changed the title feat: add C implementation for binomial Mean feat: add C implementation for stats/base/dists/binomial/mean Dec 16, 2024
@0PrashantYadav0
Copy link
Member Author

@Planeshifter Make all the changes. Please review all the changes.

@0PrashantYadav0
Copy link
Member Author

@Planeshifter Please review this, i have implemented ID_D as mention earlier.

@Planeshifter
Copy link
Member

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 8, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got around to review...

Thanks for the PR, @0PrashantYadav0! Will merge shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 8, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 8, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/binomial/mean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3681
Closes: https://github.com/stdlib-js/stdlib/issues/3469

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 95dd2ff into stdlib-js:develop Feb 8, 2025
28 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
PR-URL: stdlib-js#3681
Closes: stdlib-js#3469

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#3681
Closes: stdlib-js#3469

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/binomial/mean

3 participants