Skip to content

Conversation

AadishJ
Copy link
Contributor

@AadishJ AadishJ commented Dec 14, 2024

Resolves #3881 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the t variance.
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the t variance in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 14, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 14, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/t/variance $\color{green}169/169$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}169/169$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/t/variance feat: add C implementation for stats/base/dists/t/variance Dec 15, 2024
Copy link
Contributor

@Vinit-Pandit Vinit-Pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AadishJ You have to follow the coding style rules according to the project , please do the same for all files and all your's open PRs , you can refer other package files which have c implementations like stats/base/dists/arcsine/cdf
Cheers !

@AadishJ
Copy link
Contributor Author

AadishJ commented Dec 15, 2024

@MeastroZI I have made those changes, please check 😊

@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 18, 2025
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed bot: In Progress Pull request is currently awaiting automation. labels Jun 18, 2025
Signed-off-by: Philipp Burckhardt <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready now.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 19, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 19, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/t/variance`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3912
Closes: https://github.com/stdlib-js/stdlib/issues/3881

Co-authored-by: Aadish Jain <firestorm@AadishJain>
Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 9e54cc2 into stdlib-js:develop Jun 19, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/t/variance

4 participants