Skip to content

Conversation

@0PrashantYadav0
Copy link
Member

Resolves #3472

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/binomial/mode along with relevant tests, benchmarks and examples

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

Am i supposed to put fixtures/julia directory along with the runner.jl file ?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 16, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/binomial/mode $\color{red}174/177$
$\color{green}+98.31\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}174/177$
$\color{green}+98.31\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/binomial/mode feat: add C implementation for stats/base/dists/binomial/mode Dec 16, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @0PrashantYadav0!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 6, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 6, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/binomial/mode`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3947
Closes: https://github.com/stdlib-js/stdlib/issues/3472

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 8447e7a into stdlib-js:develop Jan 6, 2025
28 checks passed
0PrashantYadav0 added a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
PR-URL: stdlib-js#3947
Closes: stdlib-js#3472

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
PR-URL: stdlib-js#3947
Closes: stdlib-js#3472

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#3947
Closes: stdlib-js#3472

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/binomial/mode

3 participants