Skip to content

Conversation

sethdivyansh
Copy link
Contributor

@sethdivyansh sethdivyansh commented Dec 17, 2024

Resolves #3776

Description

  • adds C implementation for @stdlib/stats/base/dists/normal/mean along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2024

Coverage Report

Package Statements Branches Functions Lines
array/base/filled5d-by $\color{green}128/128$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}128/128$
$\color{green}+100.00\%$
array/base/flatten5d $\color{green}301/301$
$\color{green}+100.00\%$
$\color{green}25/25$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}301/301$
$\color{green}+100.00\%$
assert/is-camelcase $\color{green}104/104$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}104/104$
$\color{green}+100.00\%$
iter/do-until-each $\color{red}224/227$
$\color{green}+98.68\%$
$\color{red}22/23$
$\color{green}+95.65\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}224/227$
$\color{green}+98.68\%$
math/base/special/negalucasf $\color{green}221/221$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}221/221$
$\color{green}+100.00\%$
math/strided/special/asinh-by $\color{green}197/197$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}197/197$
$\color{green}+100.00\%$
ndarray $\color{green}546/546$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}546/546$
$\color{green}+100.00\%$
ndarray/map $\color{green}180/180$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}180/180$
$\color{green}+100.00\%$
repl/code-blocks $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
repl $\color{red}11592/14373$
$\color{green}+80.65\%$
$\color{red}663/895$
$\color{green}+74.08\%$
$\color{red}153/266$
$\color{green}+57.52\%$
$\color{red}11592/14373$
$\color{green}+80.65\%$
repl/help $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
repl/info $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
repl/signature $\color{green}99/99$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}99/99$
$\color{green}+100.00\%$
repl/typed-signature $\color{green}99/99$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}99/99$
$\color{green}+100.00\%$
stats/base/dists/logistic/variance $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$
stats/base/dists/lognormal/variance $\color{green}178/178$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}178/178$
$\color{green}+100.00\%$
stats/base/dists/normal/mean $\color{green}175/175$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}175/175$
$\color{green}+100.00\%$
stats/base/dists/pareto-type1/stdev $\color{green}203/203$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}203/203$
$\color{green}+100.00\%$
stats/base/dists/rayleigh/entropy $\color{green}164/164$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}164/164$
$\color{green}+100.00\%$
stats/base/dists/rayleigh/logcdf $\color{green}302/302$
$\color{green}+100.00\%$
$\color{green}31/31$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}302/302$
$\color{green}+100.00\%$
stats/base/dists/rayleigh/pdf $\color{green}295/295$
$\color{green}+100.00\%$
$\color{green}29/29$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}295/295$
$\color{green}+100.00\%$
stats/base/dists/rayleigh/variance $\color{green}162/162$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}162/162$
$\color{green}+100.00\%$
string/base/altcase $\color{green}115/115$
$\color{green}+100.00\%$
$\color{green}6/6$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}115/115$
$\color{green}+100.00\%$
string/base/constantcase $\color{red}571/576$
$\color{green}+99.13\%$
$\color{red}17/18$
$\color{green}+94.44\%$
$\color{red}5/6$
$\color{green}+83.33\%$
$\color{red}571/576$
$\color{green}+99.13\%$
string/base/trim $\color{green}379/379$
$\color{green}+100.00\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}379/379$
$\color{green}+100.00\%$
utils/none-in-by $\color{green}117/117$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}117/117$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/normal/mean feat: add C implementation for stats/base/dists/normal/mean Dec 18, 2024
I tried finding why this was disabled to begin with; however, this
predates the project, and I am not sure the origin. My guess is
that this stems from the Markdown specification allowing two spaces
to force a hard line break. By trimming trailing whitespace, that
could mean that Markdown formatting is affected. However, we do not
use two spaces to force linebreaks. Instead, we use blank lines. As
such, I think we can enable automatic whitespace trimming.
stdlib-bot and others added 15 commits December 18, 2024 13:39
PR-URL: stdlib-js#3979
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3978
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3977
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3956
Closes: stdlib-js#3799

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
PR-URL: stdlib-js#3925
Closes: stdlib-js#3866

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3957
Closes: stdlib-js#3801

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
PR-URL: stdlib-js#3945
Closes: stdlib-js#3807

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
PR-URL: stdlib-js#4010
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#4009
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter added the autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. label Apr 6, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution due to Git history issues.

Some common issues include:

  • Merge conflicts
  • Inappropriate commit messages
  • Unrelated commits
  • Including changes from merged branches that weren't intended for this PR

We recommend opening a new pull request with only the intended changes.

Thank you for your interest in stdlib, and we look forward to your future contributions.

@stdlib-bot stdlib-bot closed this Apr 6, 2025
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed Needs Review A pull request which needs code review. labels Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/normal/mean

7 participants