Skip to content

Conversation

0PrashantYadav0
Copy link
Member

Resolves #3824

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for triangular variance with proper examples, benchmarks and tests.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/triangular/variance $\color{green}197/197$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}197/197$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@0PrashantYadav0 0PrashantYadav0 changed the title feat: add C implementation for triangular variance feat: add C implementation for stats/base/dists/triangular/variance Dec 17, 2024
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@0PrashantYadav0
Copy link
Member Author

@Planeshifter Sorry for not quick response, i missed it

@0PrashantYadav0
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 8, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 10, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 10, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/triangular/variance`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4000
Closes: https://github.com/stdlib-js/stdlib/issues/3824

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 1040b76 into stdlib-js:develop Jan 10, 2025
27 checks passed
@saurabhraghuvanshii
Copy link
Contributor

@0PrashantYadav0 why on running test show error var v = variance( NaN, 1.0, 0.5 ); TypeError: variance is not a function

@0PrashantYadav0
Copy link
Member Author

Have you compiled before running.

@saurabhraghuvanshii
Copy link
Contributor

@0PrashantYadav0 it done, my system have so many problem. after pull I want to update my fork repo it show problem, and dont know why my branch always so branch have diverged. Can you help me

@0PrashantYadav0
Copy link
Member Author

@saurabhraghuvanshii If possible try to reinitailize the project. It works for me. I hope it works.

@saurabhraghuvanshii
Copy link
Contributor

@0PrashantYadav0 ok thanks , but my three pr got delete by this.

@0PrashantYadav0
Copy link
Member Author

@saurabhraghuvanshii I was telling to reinitailize the project on your local machine.

saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 10, 2025
PR-URL: stdlib-js#4000
Closes: stdlib-js#3824

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
PR-URL: stdlib-js#4000
Closes: stdlib-js#3824

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4000
Closes: stdlib-js#3824

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/triangular/variance

4 participants